[PR #2789] [MERGED] fix: error 3rdparty and compile #2949

Closed
opened 2026-10-14 21:06:26 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/2789
Author: @NickVs2015
Created: 6/30/2026
Status: ✅ Merged
Merged: 7/6/2026
Merged by: @vkamn

Base: dev ← Head: fix/3rdparty_binary_dir


📝 Commits (3)

  • f81d2f4 fix: add binary dir to add_subdirectory calls in 3rdparty.cmake
  • 7028e48 fix: use list(APPEND LIBS) instead of target_link_libraries for gamepad on Android
  • 53e5d63 fix: add core skippltgormController

📊 Changes

3 files changed (+13 additions, -9 deletions)

View changed files

📝 client/cmake/3rdparty.cmake (+5 -5)
📝 client/core/controllers/coreController.cpp (+6 -3)
📝 client/core/controllers/coreController.h (+2 -1)

📄 Description

chore fix errors


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/2789 **Author:** [@NickVs2015](https://github.com/NickVs2015) **Created:** 6/30/2026 **Status:** ✅ Merged **Merged:** 7/6/2026 **Merged by:** [@vkamn](https://github.com/vkamn) **Base:** `dev` ← **Head:** `fix/3rdparty_binary_dir` --- ### 📝 Commits (3) - [`f81d2f4`](https://github.com/amnezia-vpn/amnezia-client/commit/f81d2f4f56d8e65513eb0d31169e9db435abd5bd) fix: add binary dir to add_subdirectory calls in 3rdparty.cmake - [`7028e48`](https://github.com/amnezia-vpn/amnezia-client/commit/7028e48ee64f2e12a96e8253d2ae53b47fc1b303) fix: use list(APPEND LIBS) instead of target_link_libraries for gamepad on Android - [`53e5d63`](https://github.com/amnezia-vpn/amnezia-client/commit/53e5d63c91411e09ff3e9da161488d47883dd795) fix: add core skippltgormController ### 📊 Changes **3 files changed** (+13 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `client/cmake/3rdparty.cmake` (+5 -5) 📝 `client/core/controllers/coreController.cpp` (+6 -3) 📝 `client/core/controllers/coreController.h` (+2 -1) </details> ### 📄 Description chore fix errors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-14 21:06:26 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
amnezia-vpn/amnezia-client#2949
No description provided.