[PR #3018] test: cover CIDR split-tunneling imports #3055

New issue

Open

opened 2026-10-14 21:07:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-14 21:07:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/3018
Author: @drenderyga-del
Created: 8/22/2026
Status: 🔄 Open

Base: dev ← Head: codex/ip-split-tunneling-regression-tests

📝 Commits (1)

697f094 test: cover CIDR split-tunneling imports

📊 Changes

3 files changed (+161 additions, -0 deletions)

View changed files

📝 CMakeLists.txt (+6 -0)
➕ tests/CMakeLists.txt (+44 -0)
➕ tests/ipSplitTunnelingControllerTest.cpp (+111 -0)

📄 Description

Summary

add desktop QtTest coverage for site-based split-tunneling CIDR entries
verify manual additions and JSON import preserve IPv4 prefix lengths
verify export/re-import round-trips CIDR entries
keep URL path normalization and plain domain handling covered

This guards the normalization fix already present on dev (see #2939 and #3015) against regressions.

Validation

git diff --check
Full CMake/CTest execution was not available in the local environment because Conan/Qt dependencies are not installed.

Related to #2939

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/3018 **Author:** [@drenderyga-del](https://github.com/drenderyga-del) **Created:** 8/22/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `codex/ip-split-tunneling-regression-tests` --- ### 📝 Commits (1) - [`697f094`](https://github.com/amnezia-vpn/amnezia-client/commit/697f0941fc1bf035726ad6632966ea4de657b5dc) test: cover CIDR split-tunneling imports ### 📊 Changes **3 files changed** (+161 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+6 -0) ➕ `tests/CMakeLists.txt` (+44 -0) ➕ `tests/ipSplitTunnelingControllerTest.cpp` (+111 -0) </details> ### 📄 Description ## Summary - add desktop QtTest coverage for site-based split-tunneling CIDR entries - verify manual additions and JSON import preserve IPv4 prefix lengths - verify export/re-import round-trips CIDR entries - keep URL path normalization and plain domain handling covered This guards the normalization fix already present on `dev` (see #2939 and #3015) against regressions. ## Validation - `git diff --check` - Full CMake/CTest execution was not available in the local environment because Conan/Qt dependencies are not installed. Related to #2939 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-14 21:07:11 +00:00

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amnezia-client#3055

No description provided.

Rows
Columns