[PR #3248] [CLOSED] fix: libagw review #3147

New issue

Closed

opened 2026-10-14 21:07:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-14 21:07:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amnezia-client/pull/3248
Author: @yp-amnezia
Created: 10/1/2026
Status: ❌ Closed

Base: dev ← Head: fix/libagw-review-fixes

📝 Commits (10+)

1d5061f feat: use libagw
9eeed61 feat: add conanfile for libagw
cf549e8 chore: fix android build with agw
28b92fa Merge branch 'dev' of github-amnezia:amnezia-vpn/amnezia-client into feat/switch-to-libagw
a020e7c Merge branch 'dev' of github-amnezia:amnezia-vpn/amnezia-client into HEAD
d9760bf refactor: gateway error code parsing
e48cfab Merge branch 'dev' of github-amnezia:amnezia-vpn/amnezia-client into HEAD
2f6bed2 fix: build fixes
93aa3b6 fix: run libagw calls off the main thread
440fd2f fix: share failover state across controllers, keep the working proxy per run

📊 Changes

16 files changed (+693 additions, -730 deletions)

View changed files

📝 client/CMakeLists.txt (+4 -0)
📝 client/cmake/android.cmake (+2 -0)
📝 client/core/controllers/api/newsController.cpp (+5 -6)
📝 client/core/controllers/gatewayController.cpp (+331 -613)
📝 client/core/controllers/gatewayController.h (+27 -44)
📝 client/core/repositories/secureAppSettingsRepository.cpp (+20 -0)
📝 client/core/repositories/secureAppSettingsRepository.h (+3 -0)
📝 client/core/utils/api/apiUtils.cpp (+45 -60)
📝 client/core/utils/api/apiUtils.h (+1 -3)
📝 client/secureQSettings.cpp (+43 -4)
📝 client/secureQSettings.h (+9 -0)
📝 client/tests/CMakeLists.txt (+20 -0)
📝 client/tests/api/CMakeLists.txt (+2 -0)
📝 client/tests/selfHostedAdmin/CMakeLists.txt (+1 -0)
📝 conanfile.py (+2 -0)
➕ recipes/libagw/conanfile.py (+178 -0)

📄 Description

fix: run libagw calls off the main thread
fix: accept gateway answers without http_status
fix: stop logging server config with private keys
fix: destroy news gateway controller on its own thread
fix: keep agw failover state per environment and gateway

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amnezia-client/pull/3248 **Author:** [@yp-amnezia](https://github.com/yp-amnezia) **Created:** 10/1/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/libagw-review-fixes` --- ### 📝 Commits (10+) - [`1d5061f`](https://github.com/amnezia-vpn/amnezia-client/commit/1d5061f2fcd3d01e99a87035b8c35b876f5cad20) feat: use libagw - [`9eeed61`](https://github.com/amnezia-vpn/amnezia-client/commit/9eeed6127437ade683ebcaff7060e60c3f461122) feat: add conanfile for libagw - [`cf549e8`](https://github.com/amnezia-vpn/amnezia-client/commit/cf549e8d548ed02f6db0d0859cfb370822c6438e) chore: fix android build with agw - [`28b92fa`](https://github.com/amnezia-vpn/amnezia-client/commit/28b92fa73c8bab829db63ce4739d9cda0b5fcd72) Merge branch 'dev' of github-amnezia:amnezia-vpn/amnezia-client into feat/switch-to-libagw - [`a020e7c`](https://github.com/amnezia-vpn/amnezia-client/commit/a020e7c527a133f03983707e23a104e2be012a45) Merge branch 'dev' of github-amnezia:amnezia-vpn/amnezia-client into HEAD - [`d9760bf`](https://github.com/amnezia-vpn/amnezia-client/commit/d9760bf732594a86f43c812aed672f97bde33ee4) refactor: gateway error code parsing - [`e48cfab`](https://github.com/amnezia-vpn/amnezia-client/commit/e48cfabbf0b80110f61338078c7d1271a557d0ee) Merge branch 'dev' of github-amnezia:amnezia-vpn/amnezia-client into HEAD - [`2f6bed2`](https://github.com/amnezia-vpn/amnezia-client/commit/2f6bed28538bb811dba57bb4917a4756365a1cbc) fix: build fixes - [`93aa3b6`](https://github.com/amnezia-vpn/amnezia-client/commit/93aa3b6247e91c35a3cedf2bdcccd01b55533f84) fix: run libagw calls off the main thread - [`440fd2f`](https://github.com/amnezia-vpn/amnezia-client/commit/440fd2f6f5df1f2d6a7758b0b2cc10cf9ee382b5) fix: share failover state across controllers, keep the working proxy per run ### 📊 Changes **16 files changed** (+693 additions, -730 deletions) <details> <summary>View changed files</summary> 📝 `client/CMakeLists.txt` (+4 -0) 📝 `client/cmake/android.cmake` (+2 -0) 📝 `client/core/controllers/api/newsController.cpp` (+5 -6) 📝 `client/core/controllers/gatewayController.cpp` (+331 -613) 📝 `client/core/controllers/gatewayController.h` (+27 -44) 📝 `client/core/repositories/secureAppSettingsRepository.cpp` (+20 -0) 📝 `client/core/repositories/secureAppSettingsRepository.h` (+3 -0) 📝 `client/core/utils/api/apiUtils.cpp` (+45 -60) 📝 `client/core/utils/api/apiUtils.h` (+1 -3) 📝 `client/secureQSettings.cpp` (+43 -4) 📝 `client/secureQSettings.h` (+9 -0) 📝 `client/tests/CMakeLists.txt` (+20 -0) 📝 `client/tests/api/CMakeLists.txt` (+2 -0) 📝 `client/tests/selfHostedAdmin/CMakeLists.txt` (+1 -0) 📝 `conanfile.py` (+2 -0) ➕ `recipes/libagw/conanfile.py` (+178 -0) </details> ### 📄 Description fix: run libagw calls off the main thread fix: accept gateway answers without http_status fix: stop logging server config with private keys fix: destroy news gateway controller on its own thread fix: keep agw failover state per environment and gateway --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-14 21:07:48 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

amnezia-vpn/amnezia-client#3147

No description provided.

Rows
Columns