mirror of
https://github.com/amnezia-vpn/amneziawg-go.git
synced 2026-10-13 21:34:25 +00:00
[PR #192] test: don't copy atomic.Uint32 when reporting TestWaitPool failure #196
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
amnezia-vpn/amneziawg-go#196
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/amnezia-vpn/amneziawg-go/pull/192
Author: @artromone
Created: 9/3/2026
Status: 🔄 Open
Base:
master← Head:fix/vet-copylocks-pools-test📝 Commits (1)
b7f5b72test: don't copy atomic.Uint32 when reporting TestWaitPool failure📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
device/pools_test.go(+1 -1)📄 Description
TestWaitPool passed the atomic.Uint32 itself to t.Errorf instead of the value it had already loaded for the comparison. Formatting it copies the wrapper, and the embedded noCopy marker makes that invalid under the copylocks analyzer, so
go vet ./devicefailed on an unmodified tree:Format max.Load() instead.
go vet ./...is now clean.Fixes #157
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.