[PR #45] [CHERRY-PICK] wg-quick: linux: do not unnecessarily set sysctl #61

New issue

Open

opened 2026-10-13 21:02:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 21:02:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amnezia-vpn/amneziawg-tools/pull/45
Author: @texhobeer
Created: 4/6/2026
Status: 🔄 Open

Base: master ← Head: dev/cherry-pick-sysctl-bug

📝 Commits (1)

6daba8c wg-quick: linux: do not unnecessarily set sysctl

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/wg-quick/linux.bash (+1 -1)

📄 Description

Found a bug in some scenario while using docker. There is a fix in original WG-Quick repo for it already. TBH, I don't know the sync process of the repo, probably the maintainers are going to update the repo in the nearest future... Anyway, PTAL

--- Original commit comment ---
In some restrictive container namespaces, sysctl is locked down and can't be changed. This shouldn't be a problem, though, at least in theory, because net.ipv4.conf.all.src_valid_mark is already 1. However, currently wg-quick unconditionally sets it. Instead, check to see if it's already 1 before trying make it 1.

Suggested-by: Dean P dean@apakossa.org

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amnezia-vpn/amneziawg-tools/pull/45 **Author:** [@texhobeer](https://github.com/texhobeer) **Created:** 4/6/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `dev/cherry-pick-sysctl-bug` --- ### 📝 Commits (1) - [`6daba8c`](https://github.com/amnezia-vpn/amneziawg-tools/commit/6daba8c84d6276ef79268e786b0841c29491142e) wg-quick: linux: do not unnecessarily set sysctl ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/wg-quick/linux.bash` (+1 -1) </details> ### 📄 Description Found a bug in some scenario while using docker. There is a fix in original WG-Quick repo for it already. TBH, I don't know the sync process of the repo, probably the maintainers are going to update the repo in the nearest future... Anyway, PTAL --- Original commit comment --- In some restrictive container namespaces, sysctl is locked down and can't be changed. This shouldn't be a problem, though, at least in theory, because net.ipv4.conf.all.src_valid_mark is already 1. However, currently wg-quick unconditionally sets it. Instead, check to see if it's already 1 before trying make it 1. Suggested-by: Dean P <dean@apakossa.org> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-13 21:02:54 +00:00

bsakaguchi referenced this issue

2026-10-13 21:03:02 +00:00

[PR #74] fix: omit empty AWG 3.x ranges from showconf #75