[PR #46] [MERGED] Add apply_rope_split_half for models with this type of rope. #104

New issue

Closed

opened 2026-10-26 22:20:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:20:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfy-kitchen/pull/46
Author: @comfyanonymous
Created: 5/30/2026
Status: ✅ Merged
Merged: 5/30/2026
Merged by: @comfyanonymous

Base: main ← Head: dev/temp_pr

📝 Commits (1)

84639f4 Add apply_rope_split_half for models with this type of rope.

📊 Changes

9 files changed (+472 additions, -55 deletions)

View changed files

📝 comfy_kitchen/__init__.py (+57 -2)
📝 comfy_kitchen/backends/cuda/__init__.py (+88 -0)
📝 comfy_kitchen/backends/cuda/dlpack_bindings.cpp (+6 -2)
📝 comfy_kitchen/backends/cuda/ops/apply_rope.cu (+87 -45)
📝 comfy_kitchen/backends/eager/__init__.py (+18 -1)
📝 comfy_kitchen/backends/eager/rope.py (+47 -0)
📝 comfy_kitchen/backends/triton/__init__.py (+18 -1)
📝 comfy_kitchen/backends/triton/rope.py (+24 -4)
📝 tests/test_rope.py (+127 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfy-kitchen/pull/46 **Author:** [@comfyanonymous](https://github.com/comfyanonymous) **Created:** 5/30/2026 **Status:** ✅ Merged **Merged:** 5/30/2026 **Merged by:** [@comfyanonymous](https://github.com/comfyanonymous) **Base:** `main` ← **Head:** `dev/temp_pr` --- ### 📝 Commits (1) - [`84639f4`](https://github.com/Comfy-Org/comfy-kitchen/commit/84639f4f0717ee73cd232af982af02160411a3e2) Add apply_rope_split_half for models with this type of rope. ### 📊 Changes **9 files changed** (+472 additions, -55 deletions) <details> <summary>View changed files</summary> 📝 `comfy_kitchen/__init__.py` (+57 -2) 📝 `comfy_kitchen/backends/cuda/__init__.py` (+88 -0) 📝 `comfy_kitchen/backends/cuda/dlpack_bindings.cpp` (+6 -2) 📝 `comfy_kitchen/backends/cuda/ops/apply_rope.cu` (+87 -45) 📝 `comfy_kitchen/backends/eager/__init__.py` (+18 -1) 📝 `comfy_kitchen/backends/eager/rope.py` (+47 -0) 📝 `comfy_kitchen/backends/triton/__init__.py` (+18 -1) 📝 `comfy_kitchen/backends/triton/rope.py` (+24 -4) 📝 `tests/test_rope.py` (+127 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:20:25 +00:00