[PR #7] [MERGED] Land the merged regression stack (#3, #4, #6) on main #7

New issue

Closed

opened 2026-10-31 22:06:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 22:06:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/comfyci-runpod-worker/pull/7
Author: @marawan206
Created: 10/8/2026
Status: ✅ Merged
Merged: 10/9/2026
Merged by: @marawan206

Base: main ← Head: land-regression-stack

📝 Commits (10+)

82c3033 Add a run index for the dashboard's history view
26c783a Maintain the run index on every publish and write WebP thumbnails
ff02da6 Prefetch summaries and run records in one round trip for the index backfill
37aa1cc Record why a golden was blessed and allow promoting an existing run
59c4dd4 Look up the merged pull request for each tested commit
23c8931 Write the run summary to a file and record each workflow's prior verdict
563ec75 Add PULSE PR comments for GPU output changes
94fd78c Run the PULSE PR comment step after the regression suite
775327c Document PULSE PR comments and the prior verdict field
a931c82 Pass the commit input to the target step through env and check it is a sha

📊 Changes

19 files changed (+2535 additions, -75 deletions)

View changed files

➕ .github/workflows/build-index.yml (+44 -0)
📝 .github/workflows/golden-baseline.yml (+47 -10)
📝 .github/workflows/regression.yml (+28 -5)
📝 README.md (+99 -3)
➕ manifest/lanes.json (+18 -0)
➕ scripts/build_index.py (+58 -0)
➕ scripts/commit_meta.py (+116 -0)
📝 scripts/golden_baseline.py (+192 -23)
➕ scripts/index_builder.py (+391 -0)
➕ scripts/notify_pr.py (+371 -0)
📝 scripts/run_regression.py (+83 -1)
📝 scripts/storage.py (+43 -4)
📝 scripts/tests/conftest.py (+42 -0)
➕ scripts/tests/test_commit_meta.py (+103 -0)
➕ scripts/tests/test_golden_baseline.py (+182 -0)
➕ scripts/tests/test_index_builder.py (+246 -0)
➕ scripts/tests/test_notify_pr.py (+368 -0)
📝 scripts/tests/test_run_regression.py (+90 -1)
📝 scripts/tests/test_storage.py (+14 -28)

📄 Description

#3, #4 and #6 were merged into their stacked base branches (storage-hygiene, run-index, goldens-v2) rather than main, so main currently only has #2. This PR brings the rest of the already-reviewed stack into main. It contains no new changes.

The head is the current goldens-v2, which contains:

#3: run index for the dashboard history
#4: blessing records a reason and can promote an existing run
#6: PULSE comments on code owners' PRs (dry-run by default)

Checks:

Nothing is lost. storage-hygiene and run-index contain no commits that goldens-v2 lacks, apart from the two merge commits, whose content is already in goldens-v2.
It merges cleanly into main.
All script tests pass, and they also pass with #5 merged on top.

Once this merges, production (the scheduled GPU regression job) starts writing the run index, PR metadata and the new golden records. #5 can be merged before or after this one.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/comfyci-runpod-worker/pull/7 **Author:** [@marawan206](https://github.com/marawan206) **Created:** 10/8/2026 **Status:** ✅ Merged **Merged:** 10/9/2026 **Merged by:** [@marawan206](https://github.com/marawan206) **Base:** `main` ← **Head:** `land-regression-stack` --- ### 📝 Commits (10+) - [`82c3033`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/82c30330926f6fb271f970c19bc50d8e1c9cf570) Add a run index for the dashboard's history view - [`26c783a`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/26c783a63799b809725df6db0cfc56f3b79f96e9) Maintain the run index on every publish and write WebP thumbnails - [`ff02da6`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/ff02da69fc1c3a9b0094baa1cb9ad616a2fa269e) Prefetch summaries and run records in one round trip for the index backfill - [`37aa1cc`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/37aa1ccb4724e07314599cbef552c7ada05f85c9) Record why a golden was blessed and allow promoting an existing run - [`59c4dd4`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/59c4dd421d7934507a4dc1f9a66e75a89a974709) Look up the merged pull request for each tested commit - [`23c8931`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/23c8931ed4a3c9511d7fa03c1868136ebf93802a) Write the run summary to a file and record each workflow's prior verdict - [`563ec75`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/563ec75e60b8fbf0ddd98847244339c539dfa21c) Add PULSE PR comments for GPU output changes - [`94fd78c`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/94fd78c204e9352feaad5a4b2c9ba29e041b57a0) Run the PULSE PR comment step after the regression suite - [`775327c`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/775327ca53a6e3a43b9ed98ba730d791d04e0108) Document PULSE PR comments and the prior verdict field - [`a931c82`](https://github.com/Comfy-Org/comfyci-runpod-worker/commit/a931c8263c6f0b0ed1dc628b8ab535d7aac047ba) Pass the commit input to the target step through env and check it is a sha ### 📊 Changes **19 files changed** (+2535 additions, -75 deletions) <details> <summary>View changed files</summary> ➕ `.github/workflows/build-index.yml` (+44 -0) 📝 `.github/workflows/golden-baseline.yml` (+47 -10) 📝 `.github/workflows/regression.yml` (+28 -5) 📝 `README.md` (+99 -3) ➕ `manifest/lanes.json` (+18 -0) ➕ `scripts/build_index.py` (+58 -0) ➕ `scripts/commit_meta.py` (+116 -0) 📝 `scripts/golden_baseline.py` (+192 -23) ➕ `scripts/index_builder.py` (+391 -0) ➕ `scripts/notify_pr.py` (+371 -0) 📝 `scripts/run_regression.py` (+83 -1) 📝 `scripts/storage.py` (+43 -4) 📝 `scripts/tests/conftest.py` (+42 -0) ➕ `scripts/tests/test_commit_meta.py` (+103 -0) ➕ `scripts/tests/test_golden_baseline.py` (+182 -0) ➕ `scripts/tests/test_index_builder.py` (+246 -0) ➕ `scripts/tests/test_notify_pr.py` (+368 -0) 📝 `scripts/tests/test_run_regression.py` (+90 -1) 📝 `scripts/tests/test_storage.py` (+14 -28) </details> ### 📄 Description #3, #4 and #6 were merged into their stacked base branches (`storage-hygiene`, `run-index`, `goldens-v2`) rather than `main`, so `main` currently only has #2. This PR brings the rest of the already-reviewed stack into `main`. It contains no new changes. The head is the current `goldens-v2`, which contains: - #3: run index for the dashboard history - #4: blessing records a reason and can promote an existing run - #6: PULSE comments on code owners' PRs (dry-run by default) Checks: - Nothing is lost. `storage-hygiene` and `run-index` contain no commits that `goldens-v2` lacks, apart from the two merge commits, whose content is already in `goldens-v2`. - It merges cleanly into `main`. - All script tests pass, and they also pass with #5 merged on top. Once this merges, production (the scheduled GPU regression job) starts writing the run index, PR metadata and the new golden records. #5 can be merged before or after this one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 22:06:12 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Comfy-Org/comfyci-runpod-worker#7

No description provided.

Rows
Columns