From 3a5b71a929c90444a54b7d7af53e9c8cf762f25b Mon Sep 17 00:00:00 2001 From: Luke Mino-Altherr Date: Fri, 6 Feb 2026 15:36:03 -0800 Subject: [PATCH] Fix inconsistent nullability handling for size_bytes in routes.py Since size_bytes is declared as non-nullable (nullable=False, default=0) in the Asset model, simplify the conditional checks: - Use 'if item.asset else None' when the asset relationship might be None - Access size_bytes directly when asset is guaranteed to exist (create endpoints) Amp-Thread-ID: https://ampcode.com/threads/T-019c354e-cbfb-77d8-acdd-0d066c16006e Co-authored-by: Amp --- app/assets/api/routes.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/app/assets/api/routes.py b/app/assets/api/routes.py index 9c7bd1e72..74364d445 100644 --- a/app/assets/api/routes.py +++ b/app/assets/api/routes.py @@ -146,9 +146,7 @@ async def list_assets_route(request: web.Request) -> web.Response: id=item.info.id, name=item.info.name, asset_hash=item.asset.hash if item.asset else None, - size=int(item.asset.size_bytes) - if item.asset and item.asset.size_bytes - else None, + size=int(item.asset.size_bytes) if item.asset else None, mime_type=item.asset.mime_type if item.asset else None, tags=item.tags, created_at=item.info.created_at, @@ -189,9 +187,7 @@ async def get_asset_route(request: web.Request) -> web.Response: id=result.info.id, name=result.info.name, asset_hash=result.asset.hash if result.asset else None, - size=int(result.asset.size_bytes) - if result.asset and result.asset.size_bytes is not None - else None, + size=int(result.asset.size_bytes) if result.asset else None, mime_type=result.asset.mime_type if result.asset else None, tags=result.tags, user_metadata=result.info.user_metadata or {}, @@ -296,7 +292,7 @@ async def create_asset_from_hash_route(request: web.Request) -> web.Response: id=result.info.id, name=result.info.name, asset_hash=result.asset.hash, - size=int(result.asset.size_bytes) if result.asset.size_bytes else None, + size=int(result.asset.size_bytes), mime_type=result.asset.mime_type, tags=result.tags, user_metadata=result.info.user_metadata or {}, @@ -399,7 +395,7 @@ async def upload_asset(request: web.Request) -> web.Response: id=result.info.id, name=result.info.name, asset_hash=result.asset.hash, - size=int(result.asset.size_bytes) if result.asset.size_bytes else None, + size=int(result.asset.size_bytes), mime_type=result.asset.mime_type, tags=result.tags, user_metadata=result.info.user_metadata or {},