refactor: rename functions to verb-based naming convention

Rename functions across app/assets/ to follow verb-based naming:
- is_scalar → check_is_scalar
- project_kv → expand_metadata_to_rows
- _visible_owner_clause → _build_visible_owner_clause
- _chunk_rows → _iter_row_chunks
- _at_least_one → _validate_at_least_one_field
- _tags_norm → _normalize_tags_field
- _ser_dt → _serialize_datetime
- _ser_updated → _serialize_updated_at
- _error_response → _build_error_response
- _validation_error_response → _build_validation_error_response
- file_sender → stream_file_chunks
- seed_assets_endpoint → seed_assets
- utcnow → get_utc_now
- _safe_sort_field → _validate_sort_field
- _safe_filename → _sanitize_filename
- fast_asset_file_check → check_asset_file_fast
- prefixes_for_root → get_prefixes_for_root
- blake3_hash → compute_blake3_hash
- blake3_hash_async → compute_blake3_hash_async
- _is_within → _check_is_within
- _rel → _compute_relative

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

tests-unit/assets_test/queries/test_asset_info.py

@@ -22,7 +22,7 @@ from app.assets.database.queries import (
     ensure_tags_exist,
     add_tags_to_asset_info,
 )
-from app.assets.helpers import utcnow
+from app.assets.helpers import get_utc_now
 
 
 def _make_asset(session: Session, hash_val: str | None = None, size: int = 1024) -> Asset:
@@ -38,7 +38,7 @@ def _make_asset_info(
     name: str = "test",
     owner_id: str = "",
 ) -> AssetInfo:
-    now = utcnow()
+    now = get_utc_now()
     info = AssetInfo(
         owner_id=owner_id,
         name=name,
@@ -423,7 +423,7 @@ class TestReplaceAssetInfoMetadataProjection:
 class TestBulkInsertAssetInfosIgnoreConflicts:
     def test_inserts_multiple_infos(self, session: Session):
         asset = _make_asset(session, "hash1")
-        now = utcnow()
+        now = get_utc_now()
         rows = [
             {
                 "id": str(uuid.uuid4()),
@@ -459,7 +459,7 @@ class TestBulkInsertAssetInfosIgnoreConflicts:
         _make_asset_info(session, asset, name="existing.bin", owner_id="")
         session.commit()
 
-        now = utcnow()
+        now = get_utc_now()
         rows = [
             {
                 "id": str(uuid.uuid4()),

tests-unit/assets_test/queries/test_cache_state.py

@@ -15,7 +15,7 @@ from app.assets.database.queries import (
     bulk_insert_cache_states_ignore_conflicts,
     get_cache_states_by_paths_and_asset_ids,
 )
-from app.assets.helpers import pick_best_live_path, utcnow
+from app.assets.helpers import pick_best_live_path, get_utc_now
 
 
 def _make_asset(session: Session, hash_val: str | None = None, size: int = 1024) -> Asset:
@@ -228,7 +228,7 @@ class TestGetOrphanedSeedAssetIds:
 class TestDeleteAssetsByIds:
     def test_deletes_assets_and_infos(self, session: Session):
         asset = _make_asset(session, "hash1")
-        now = utcnow()
+        now = get_utc_now()
         info = AssetInfo(
             owner_id="", name="test", asset_id=asset.id,
             created_at=now, updated_at=now, last_access_time=now
@@ -325,7 +325,7 @@ class TestDeleteCacheStatesByIds:
 class TestDeleteOrphanedSeedAsset:
     def test_deletes_seed_asset_and_infos(self, session: Session):
         asset = _make_asset(session, hash_val=None)
-        now = utcnow()
+        now = get_utc_now()
         info = AssetInfo(
             owner_id="", name="test", asset_id=asset.id,
             created_at=now, updated_at=now, last_access_time=now

tests-unit/assets_test/queries/test_metadata.py

@@ -3,8 +3,8 @@ from sqlalchemy.orm import Session
 
 from app.assets.database.models import Asset, AssetInfo, AssetInfoMeta
 from app.assets.database.queries import list_asset_infos_page
-from app.assets.database.queries.asset_info import project_kv
-from app.assets.helpers import utcnow
+from app.assets.database.queries.asset_info import expand_metadata_to_rows
+from app.assets.helpers import get_utc_now
 
 
 def _make_asset(session: Session, hash_val: str) -> Asset:
@@ -20,7 +20,7 @@ def _make_asset_info(
     name: str,
     metadata: dict | None = None,
 ) -> AssetInfo:
-    now = utcnow()
+    now = get_utc_now()
     info = AssetInfo(
         owner_id="",
         name=name,
@@ -35,7 +35,7 @@ def _make_asset_info(
 
     if metadata:
         for key, val in metadata.items():
-            for row in project_kv(key, val):
+            for row in expand_metadata_to_rows(key, val):
                 meta_row = AssetInfoMeta(
                     asset_info_id=info.id,
                     key=row["key"],

tests-unit/assets_test/queries/test_tags.py

@@ -13,7 +13,7 @@ from app.assets.database.queries import (
     list_tags_with_usage,
     bulk_insert_tags_and_meta,
 )
-from app.assets.helpers import utcnow
+from app.assets.helpers import get_utc_now
 
 
 def _make_asset(session: Session, hash_val: str | None = None) -> Asset:
@@ -24,7 +24,7 @@ def _make_asset(session: Session, hash_val: str | None = None) -> Asset:
 
 
 def _make_asset_info(session: Session, asset: Asset, name: str = "test", owner_id: str = "") -> AssetInfo:
-    now = utcnow()
+    now = get_utc_now()
     info = AssetInfo(
         owner_id=owner_id,
         name=name,
@@ -87,8 +87,8 @@ class TestGetAssetTags:
 
         ensure_tags_exist(session, ["tag1", "tag2"])
         session.add_all([
-            AssetInfoTag(asset_info_id=info.id, tag_name="tag1", origin="manual", added_at=utcnow()),
-            AssetInfoTag(asset_info_id=info.id, tag_name="tag2", origin="manual", added_at=utcnow()),
+            AssetInfoTag(asset_info_id=info.id, tag_name="tag1", origin="manual", added_at=get_utc_now()),
+            AssetInfoTag(asset_info_id=info.id, tag_name="tag2", origin="manual", added_at=get_utc_now()),
         ])
         session.flush()
 
@@ -305,7 +305,7 @@ class TestBulkInsertTagsAndMeta:
         ensure_tags_exist(session, ["bulk-tag1", "bulk-tag2"])
         session.commit()
 
-        now = utcnow()
+        now = get_utc_now()
         tag_rows = [
             {"asset_info_id": info.id, "tag_name": "bulk-tag1", "origin": "manual", "added_at": now},
             {"asset_info_id": info.id, "tag_name": "bulk-tag2", "origin": "manual", "added_at": now},
@@ -347,7 +347,7 @@ class TestBulkInsertTagsAndMeta:
         add_tags_to_asset_info(session, asset_info_id=info.id, tags=["existing-tag"])
         session.commit()
 
-        now = utcnow()
+        now = get_utc_now()
         tag_rows = [
             {"asset_info_id": info.id, "tag_name": "existing-tag", "origin": "duplicate", "added_at": now},
         ]