From d755f7ca193261040369d46fc860649b5bfcd636 Mon Sep 17 00:00:00 2001 From: Deep Mehta Date: Thu, 29 Jan 2026 19:50:12 +0530 Subject: [PATCH] docs: clarify should_cache filtering criteria MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change docstring from "Skip large values" to "Skip if download time > compute time" which better captures the cost/benefit tradeoff for external caching. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- comfy_execution/cache_provider.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/comfy_execution/cache_provider.py b/comfy_execution/cache_provider.py index 63fba5632..50bbaed34 100644 --- a/comfy_execution/cache_provider.py +++ b/comfy_execution/cache_provider.py @@ -122,8 +122,8 @@ class CacheProvider(ABC): Return False to skip external caching for this node. Common filters: - - By class_type: Only expensive nodes (KSampler, VAEDecode) - - By size: Skip large values to reduce network overhead + - By class_type: Only cache expensive nodes (KSampler, VAEDecode) + - By cost/benefit: Skip if download time > compute time Default: Returns True (cache everything). """