mirror of
https://github.com/comfyanonymous/ComfyUI.git
synced 2026-04-21 15:09:17 +00:00
chore: remove obvious/self-documenting comments from assets package
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -15,15 +15,12 @@ from app.assets.services.tagging import (
|
||||
)
|
||||
|
||||
__all__ = [
|
||||
# ingest.py
|
||||
"ingest_file_from_path",
|
||||
"register_existing_asset",
|
||||
# asset_management.py
|
||||
"get_asset_detail",
|
||||
"update_asset_metadata",
|
||||
"delete_asset_reference",
|
||||
"set_asset_preview",
|
||||
# tagging.py
|
||||
"apply_tags",
|
||||
"remove_tags",
|
||||
"list_tags",
|
||||
|
||||
@@ -74,10 +74,8 @@ def update_asset_metadata(
|
||||
update_asset_info_name(session, asset_info_id=asset_info_id, name=name)
|
||||
touched = True
|
||||
|
||||
# Compute filename from best live path
|
||||
computed_filename = _compute_filename_for_asset(session, info.asset_id)
|
||||
|
||||
# Determine if metadata needs updating
|
||||
new_meta: dict | None = None
|
||||
if user_metadata is not None:
|
||||
new_meta = dict(user_metadata)
|
||||
@@ -106,7 +104,6 @@ def update_asset_metadata(
|
||||
if touched and user_metadata is None:
|
||||
update_asset_info_updated_at(session, asset_info_id=asset_info_id)
|
||||
|
||||
# Fetch updated info with tags
|
||||
result = fetch_asset_info_asset_and_tags(
|
||||
session,
|
||||
asset_info_id=asset_info_id,
|
||||
@@ -116,7 +113,6 @@ def update_asset_metadata(
|
||||
raise RuntimeError("State changed during update")
|
||||
|
||||
info, asset, tag_list = result
|
||||
# Extract plain data before session closes
|
||||
detail = AssetDetailResult(
|
||||
info=extract_info_data(info),
|
||||
asset=extract_asset_data(asset),
|
||||
@@ -203,7 +199,6 @@ def set_asset_preview(
|
||||
raise RuntimeError("State changed during preview update")
|
||||
|
||||
info, asset, tags = result
|
||||
# Extract plain data before session closes
|
||||
detail = AssetDetailResult(
|
||||
info=extract_info_data(info),
|
||||
asset=extract_asset_data(asset),
|
||||
|
||||
@@ -73,7 +73,6 @@ def _hash_file_obj(file_obj: IO, chunk_size: int = DEFAULT_CHUNK) -> str:
|
||||
orig_pos = file_obj.tell()
|
||||
|
||||
try:
|
||||
# seek to the beginning before reading
|
||||
if orig_pos != 0:
|
||||
file_obj.seek(0)
|
||||
|
||||
|
||||
@@ -60,12 +60,10 @@ def ingest_file_from_path(
|
||||
}
|
||||
|
||||
with create_session() as session:
|
||||
# Validate preview_id if provided
|
||||
if preview_id:
|
||||
if not session.get(Asset, preview_id):
|
||||
preview_id = None
|
||||
|
||||
# 1. Upsert Asset
|
||||
asset, created, updated = upsert_asset(
|
||||
session,
|
||||
asset_hash=asset_hash,
|
||||
@@ -75,7 +73,6 @@ def ingest_file_from_path(
|
||||
out["asset_created"] = created
|
||||
out["asset_updated"] = updated
|
||||
|
||||
# 2. Upsert CacheState
|
||||
state_created, state_updated = upsert_cache_state(
|
||||
session,
|
||||
asset_id=asset.id,
|
||||
@@ -85,7 +82,6 @@ def ingest_file_from_path(
|
||||
out["state_created"] = state_created
|
||||
out["state_updated"] = state_updated
|
||||
|
||||
# 3. Optionally create/update AssetInfo
|
||||
if info_name:
|
||||
info, info_created = get_or_create_asset_info(
|
||||
session,
|
||||
@@ -100,7 +96,6 @@ def ingest_file_from_path(
|
||||
update_asset_info_timestamps(session, asset_info=info, preview_id=preview_id)
|
||||
out["asset_info_id"] = info.id
|
||||
|
||||
# 4. Handle tags
|
||||
norm = normalize_tags(list(tags))
|
||||
if norm and out["asset_info_id"]:
|
||||
if require_existing_tags:
|
||||
@@ -113,7 +108,6 @@ def ingest_file_from_path(
|
||||
create_if_missing=not require_existing_tags,
|
||||
)
|
||||
|
||||
# 5. Update metadata with computed filename
|
||||
if out["asset_info_id"]:
|
||||
_update_metadata_with_filename(
|
||||
session,
|
||||
@@ -123,7 +117,6 @@ def ingest_file_from_path(
|
||||
user_metadata=user_metadata,
|
||||
)
|
||||
|
||||
# 6. Remove missing tag
|
||||
try:
|
||||
remove_missing_tag_for_asset_id(session, asset_id=asset.id)
|
||||
except Exception:
|
||||
@@ -161,9 +154,7 @@ def register_existing_asset(
|
||||
)
|
||||
|
||||
if not info_created:
|
||||
# Return existing info
|
||||
tag_names = get_asset_tags(session, asset_info_id=info.id)
|
||||
# Extract plain data before session closes
|
||||
result = RegisterAssetResult(
|
||||
info=extract_info_data(info),
|
||||
asset=extract_asset_data(asset),
|
||||
@@ -173,7 +164,6 @@ def register_existing_asset(
|
||||
session.commit()
|
||||
return result
|
||||
|
||||
# New info - apply metadata and tags
|
||||
new_meta = dict(user_metadata or {})
|
||||
computed_filename = _compute_filename_for_asset(session, asset.id)
|
||||
if computed_filename:
|
||||
@@ -195,9 +185,7 @@ def register_existing_asset(
|
||||
)
|
||||
|
||||
tag_names = get_asset_tags(session, asset_info_id=info.id)
|
||||
# Refresh to get updated metadata after set_asset_info_metadata
|
||||
session.refresh(info)
|
||||
# Extract plain data before session closes
|
||||
result = RegisterAssetResult(
|
||||
info=extract_info_data(info),
|
||||
asset=extract_asset_data(asset),
|
||||
|
||||
Reference in New Issue
Block a user