deepseek-ai/3FS
1
0
Fork 0
mirror of https://github.com/deepseek-ai/3FS.git synced 2026-11-05 00:47:47 +00:00
Code Issues 166 Projects Packages Wiki Activity

[PR #43] [MERGED] add fmt:: namespace to distinguish from std::format_to #263

New issue
Closed
opened 2026-10-26 09:48:02 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 09:48:02 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/43
Author: @huww98
Created: 3/2/2025
Status: ✅ Merged
Merged: 3/3/2025
Merged by: @SF-Zhou

Base: main ← Head: format_to

📝 Commits (1)

  • 63518e2 add fmt:: namespace to distinguish from std::format_to

📊 Changes

13 files changed (+56 additions, -56 deletions)

View changed files

📝 src/client/meta/ServerSelectionStrategy.h (+1 -1)
📝 src/client/storage/StorageClient.h (+9 -9)
📝 src/common/app/AppInfo.h (+3 -3)
📝 src/common/app/ClientId.h (+1 -1)
📝 src/common/utils/OptionalUtils.h (+2 -2)
📝 src/common/utils/Result.h (+1 -1)
📝 src/common/utils/Status.h (+2 -2)
📝 src/common/utils/StrongType.h (+5 -5)
📝 src/fbs/core/user/User.h (+5 -5)
📝 src/fbs/meta/Schema.h (+4 -4)
📝 src/fbs/mgmtd/ChainRef.h (+1 -1)
📝 src/fbs/storage/Common.h (+17 -17)
📝 src/meta/components/SessionManager.h (+5 -5)

📄 Description

When compiled with new toolchain that implements std::format_to, it become ambiguous on which one should be called. Due to argument-dependent lookup, even if we are not using namespace std; the std version is still considered. So let's add fmt:: to avoid ambiguous compilation error.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/43 **Author:** [@huww98](https://github.com/huww98) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `format_to` --- ### 📝 Commits (1) - [`63518e2`](https://github.com/deepseek-ai/3FS/commit/63518e21bd93c337bb96b8791c197c017dad7cf0) add fmt:: namespace to distinguish from std::format_to ### 📊 Changes **13 files changed** (+56 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/client/meta/ServerSelectionStrategy.h` (+1 -1) 📝 `src/client/storage/StorageClient.h` (+9 -9) 📝 `src/common/app/AppInfo.h` (+3 -3) 📝 `src/common/app/ClientId.h` (+1 -1) 📝 `src/common/utils/OptionalUtils.h` (+2 -2) 📝 `src/common/utils/Result.h` (+1 -1) 📝 `src/common/utils/Status.h` (+2 -2) 📝 `src/common/utils/StrongType.h` (+5 -5) 📝 `src/fbs/core/user/User.h` (+5 -5) 📝 `src/fbs/meta/Schema.h` (+4 -4) 📝 `src/fbs/mgmtd/ChainRef.h` (+1 -1) 📝 `src/fbs/storage/Common.h` (+17 -17) 📝 `src/meta/components/SessionManager.h` (+5 -5) </details> ### 📄 Description When compiled with new toolchain that implements std::format_to, it become ambiguous on which one should be called. Due to argument-dependent lookup, even if we are not `using namespace std;` the std version is still considered. So let's add fmt:: to avoid ambiguous compilation error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 09:48:02 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
SF-Zhou-patch-1
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/3FS#263
No description provided.