[PR #41] [MERGED] add missing headers for new toolchain #264

New issue

Closed

opened 2026-10-26 09:48:02 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 09:48:02 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/41
Author: @huww98
Created: 3/2/2025
Status: ✅ Merged
Merged: 3/2/2025
Merged by: @SF-Zhou

Base: main ← Head: missing-headers

📝 Commits (1)

b44653f add missing headers for new toolchain

📊 Changes

12 files changed (+14 additions, -1 deletions)

View changed files

📝 benchmarks/storage_bench/StorageBench.h (+1 -0)
📝 src/client/cli/admin/DumpChainTable.cc (+1 -0)
📝 src/client/cli/admin/DumpChains.cc (+1 -0)
📝 src/client/cli/admin/DumpChunkMeta.cc (+1 -0)
📝 src/client/cli/admin/DumpInodes.cc (+2 -1)
📝 src/client/cli/admin/RenderConfig.cc (+1 -0)
📝 src/common/utils/VersionInfo.h (+1 -0)
📝 src/fuse/FuseOps.cc (+1 -0)
📝 src/storage/store/StorageTarget.cc (+1 -0)
📝 src/storage/worker/CheckWorker.cc (+2 -0)
📝 src/storage/worker/DumpWorker.cc (+1 -0)
📝 tests/meta/event/TestEventLogger.cc (+1 -0)

📄 Description

These are necessary for compiling with Ubuntu 24.04 default toolchain/boost.

Greate job! I've tried to run this on Ubuntu 24.04, facing a lot of issues. I eventually failed because I cannot install the RDMA driver. But I don't want to waste my work. So here is part of my modifications to make it compile.

See also

With these change, plus some changes to third_party, I'm able to build this on Ubuntu 24.04, with -Werror removed and https://github.com/google/leveldb/pull/1255, https://github.com/ClickHouse/clickhouse-cpp/pull/296, https://github.com/facebook/rocksdb/pull/11118

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/41 **Author:** [@huww98](https://github.com/huww98) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/2/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `missing-headers` --- ### 📝 Commits (1) - [`b44653f`](https://github.com/deepseek-ai/3FS/commit/b44653fe6fa2d12140a13a84b88c2e522fb4d2af) add missing headers for new toolchain ### 📊 Changes **12 files changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `benchmarks/storage_bench/StorageBench.h` (+1 -0) 📝 `src/client/cli/admin/DumpChainTable.cc` (+1 -0) 📝 `src/client/cli/admin/DumpChains.cc` (+1 -0) 📝 `src/client/cli/admin/DumpChunkMeta.cc` (+1 -0) 📝 `src/client/cli/admin/DumpInodes.cc` (+2 -1) 📝 `src/client/cli/admin/RenderConfig.cc` (+1 -0) 📝 `src/common/utils/VersionInfo.h` (+1 -0) 📝 `src/fuse/FuseOps.cc` (+1 -0) 📝 `src/storage/store/StorageTarget.cc` (+1 -0) 📝 `src/storage/worker/CheckWorker.cc` (+2 -0) 📝 `src/storage/worker/DumpWorker.cc` (+1 -0) 📝 `tests/meta/event/TestEventLogger.cc` (+1 -0) </details> ### 📄 Description These are necessary for compiling with Ubuntu 24.04 default toolchain/boost. Greate job! I've tried to run this on Ubuntu 24.04, facing a lot of issues. I eventually failed because I cannot install the RDMA driver. But I don't want to waste my work. So here is part of my modifications to make it compile. See also - #43 - #44 - #45 - #46 With these change, plus some changes to third_party, I'm able to build this on Ubuntu 24.04, with `-Werror` removed and https://github.com/google/leveldb/pull/1255, https://github.com/ClickHouse/clickhouse-cpp/pull/296, https://github.com/facebook/rocksdb/pull/11118 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 09:48:02 +00:00