deepseek-ai/3FS
1
0
Fork 0
mirror of https://github.com/deepseek-ai/3FS.git synced 2026-11-05 00:47:47 +00:00
Code Issues 166 Projects Packages Wiki Activity

[PR #44] [MERGED] robin hood: resolve warning on new clang #265

New issue
Closed
opened 2026-10-26 09:48:02 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 09:48:02 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/44
Author: @huww98
Created: 3/2/2025
Status: ✅ Merged
Merged: 3/3/2025
Merged by: @SF-Zhou

Base: main ← Head: robin_hood

📝 Commits (1)

  • 0378677 robin hood: resolve warning on new clang

📊 Changes

1 file changed (+1 additions, -9 deletions)

View changed files

📝 src/common/utils/RobinHood.h (+1 -9)

📄 Description

Clang has this weird behavior of setting __GNUC__ to 4, hence clang will always take the if branch. This is suboptimal because std::is_trivially_copyable has almost always been in clang.

starting with clang 15 a warning is raised for the current implementation: warning: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Wdeprecated-builtins]

Since we are using -Werror, we should fix this.

Note this resolves the same issue with https://github.com/martinus/robin-hood-hashing/pull/166 , but with a different patch.
But that PR is never released, and the original repo is archived. So, I just removed this helper. GCC4 is too old to support.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/44 **Author:** [@huww98](https://github.com/huww98) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `robin_hood` --- ### 📝 Commits (1) - [`0378677`](https://github.com/deepseek-ai/3FS/commit/0378677b54ea70cb0534020a2b684cc5fe48345c) robin hood: resolve warning on new clang ### 📊 Changes **1 file changed** (+1 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/common/utils/RobinHood.h` (+1 -9) </details> ### 📄 Description Clang has this weird behavior of setting `__GNUC__` to 4, hence clang will always take the if branch. This is suboptimal because std::is_trivially_copyable has almost always been in clang. starting with clang 15 a warning is raised for the current implementation: warning: builtin __has_trivial_copy is deprecated; use __is_trivially_copyable instead [-Wdeprecated-builtins] Since we are using -Werror, we should fix this. Note this resolves the same issue with https://github.com/martinus/robin-hood-hashing/pull/166 , but with a different patch. But that PR is never released, and the original repo is archived. So, I just removed this helper. GCC4 is too old to support. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 09:48:02 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
SF-Zhou-patch-1
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/3FS#265
No description provided.