[PR #46] [MERGED] explicit down cast #267

New issue

Closed

opened 2026-10-26 09:48:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 09:48:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/46
Author: @huww98
Created: 3/2/2025
Status: ✅ Merged
Merged: 3/3/2025
Merged by: @SF-Zhou

Base: main ← Head: cast

📝 Commits (1)

c6e3dce explicit down cast

📊 Changes

5 files changed (+6 additions, -6 deletions)

View changed files

📝 benchmarks/storage_bench/StorageBench.cc (+1 -1)
📝 src/client/storage/UpdateChannelAllocator.cc (+2 -2)
📝 src/fuse/UserConfig.cc (+1 -1)
📝 tests/analytics/TestStructuredTraceLog.cc (+1 -1)
📝 tests/lib/UnitTestFabric.cc (+1 -1)

📄 Description

Newer clang does not allow down cast with brace initialization. Replace them with C-style cast.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/46 **Author:** [@huww98](https://github.com/huww98) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `cast` --- ### 📝 Commits (1) - [`c6e3dce`](https://github.com/deepseek-ai/3FS/commit/c6e3dcede93450722781c38942cd0fa64baa96b8) explicit down cast ### 📊 Changes **5 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `benchmarks/storage_bench/StorageBench.cc` (+1 -1) 📝 `src/client/storage/UpdateChannelAllocator.cc` (+2 -2) 📝 `src/fuse/UserConfig.cc` (+1 -1) 📝 `tests/analytics/TestStructuredTraceLog.cc` (+1 -1) 📝 `tests/lib/UnitTestFabric.cc` (+1 -1) </details> ### 📄 Description Newer clang does not allow down cast with brace initialization. Replace them with C-style cast. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 09:48:03 +00:00