deepseek-ai/3FS
1
0
Fork 0
mirror of https://github.com/deepseek-ai/3FS.git synced 2026-11-05 00:47:47 +00:00
Code Issues 166 Projects Packages Wiki Activity

[PR #56] [MERGED] Minor optimize copying of shared_ptr in IBSocket and StorageTargets #270

New issue
Closed
opened 2026-10-26 09:48:06 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 09:48:06 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/56
Author: @mapleFU
Created: 3/3/2025
Status: ✅ Merged
Merged: 3/3/2025
Merged by: @SF-Zhou

Base: main ← Head: minor-silly-opt

📝 Commits (1)

  • df7bdde Minor optimize copying of shared_ptr in IBSocket and StorageTargets

📊 Changes

3 files changed (+5 additions, -5 deletions)

View changed files

📝 src/common/net/ib/IBSocket.cc (+1 -1)
📝 src/common/net/ib/IBSocket.h (+1 -1)
📝 src/storage/store/StorageTargets.cc (+3 -3)

📄 Description

I notice IBSocket and StorageTargets would copying the pointer during constructor or erasing, which might introduce unneccssary costs.

Feel free to close this since it's just low-quality contribution :-)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/56 **Author:** [@mapleFU](https://github.com/mapleFU) **Created:** 3/3/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `minor-silly-opt` --- ### 📝 Commits (1) - [`df7bdde`](https://github.com/deepseek-ai/3FS/commit/df7bdde1bad14935fd5516b36b9c1da05cbdc6ce) Minor optimize copying of shared_ptr in IBSocket and StorageTargets ### 📊 Changes **3 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/common/net/ib/IBSocket.cc` (+1 -1) 📝 `src/common/net/ib/IBSocket.h` (+1 -1) 📝 `src/storage/store/StorageTargets.cc` (+3 -3) </details> ### 📄 Description I notice IBSocket and StorageTargets would copying the pointer during constructor or erasing, which might introduce unneccssary costs. Feel free to close this since it's just low-quality contribution :-) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 09:48:06 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
SF-Zhou-patch-1
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/3FS#270
No description provided.