[PR #61] [CLOSED] Refactor: Replace magic number with constexpr for better readability #274

Closed
opened 2026-10-26 09:48:09 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/61
Author: @ufo2243
Created: 3/3/2025
Status: ❌ Closed

Base: main ← Head: main


📝 Commits (1)

  • 5094752 Refactor: Replace magic number with constexpr for better readability

📊 Changes

2 files changed (+3 additions, -1 deletions)

View changed files

📝 src/fbs/meta/Common.h (+2 -0)
📝 src/fbs/meta/Service.h (+1 -1)

📄 Description

Replaced the hardcoded value 32 with DefaultRemoveChunksBatchSize to improve readability and maintainability.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/61 **Author:** [@ufo2243](https://github.com/ufo2243) **Created:** 3/3/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`5094752`](https://github.com/deepseek-ai/3FS/commit/50947527bc1a4f08b7d7ba7cb4b2db0db8f8b3f5) Refactor: Replace magic number with constexpr for better readability ### 📊 Changes **2 files changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/fbs/meta/Common.h` (+2 -0) 📝 `src/fbs/meta/Service.h` (+1 -1) </details> ### 📄 Description Replaced the hardcoded value `32` with `DefaultRemoveChunksBatchSize` to improve readability and maintainability. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 09:48:09 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/3FS#274
No description provided.