[PR #90] [CLOSED] Use consistent styles for cmake scripts #288

New issue

Closed

opened 2026-10-26 09:48:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 09:48:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/90
Author: @zchrissirhcz
Created: 3/4/2025
Status: ❌ Closed

Base: main ← Head: adjust-cmake-style

📝 Commits (1)

92c1ff6 Use consistent styles for cmake scripts

📊 Changes

13 files changed (+140 additions, -135 deletions)

View changed files

📝 CMakeLists.txt (+30 -30)
📝 cmake/AddCrate.cmake (+3 -3)
📝 cmake/ApacheArrow.cmake (+1 -1)
📝 cmake/CLangFormat.cmake (+6 -4)
📝 cmake/CompileFlags.cmake (+16 -16)
📝 cmake/DumpConfig.cmake (+15 -13)
📝 cmake/GitVersion.cmake (+39 -39)
📝 cmake/Jemalloc.cmake (+9 -8)
📝 cmake/Target.cmake (+11 -11)
📝 src/fuse/CMakeLists.txt (+2 -2)
📝 src/lib/py/CMakeLists.txt (+6 -6)
📝 tests/client/CMakeLists.txt (+0 -1)
📝 tests/scripts/CMakeLists.txt (+2 -1)

📄 Description

Hi, 3FS maintainers

This PR adjust CMakeLists.txt and *.cmake files for consistent coding styles:

Use 4 spaces as indentation
No space between commands(e.g. if, else, set) and (
Keep the position of ) on a new line for a multiline command
Always Use lowercase cmake builtin commands

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/90 **Author:** [@zchrissirhcz](https://github.com/zchrissirhcz) **Created:** 3/4/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `adjust-cmake-style` --- ### 📝 Commits (1) - [`92c1ff6`](https://github.com/deepseek-ai/3FS/commit/92c1ff6aeed01c8c719a785855a248fc36a08fbb) Use consistent styles for cmake scripts ### 📊 Changes **13 files changed** (+140 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+30 -30) 📝 `cmake/AddCrate.cmake` (+3 -3) 📝 `cmake/ApacheArrow.cmake` (+1 -1) 📝 `cmake/CLangFormat.cmake` (+6 -4) 📝 `cmake/CompileFlags.cmake` (+16 -16) 📝 `cmake/DumpConfig.cmake` (+15 -13) 📝 `cmake/GitVersion.cmake` (+39 -39) 📝 `cmake/Jemalloc.cmake` (+9 -8) 📝 `cmake/Target.cmake` (+11 -11) 📝 `src/fuse/CMakeLists.txt` (+2 -2) 📝 `src/lib/py/CMakeLists.txt` (+6 -6) 📝 `tests/client/CMakeLists.txt` (+0 -1) 📝 `tests/scripts/CMakeLists.txt` (+2 -1) </details> ### 📄 Description Hi, 3FS maintainers This PR adjust `CMakeLists.txt` and `*.cmake` files for consistent coding styles: - Use 4 spaces as indentation - No space between commands(e.g. `if`, `else`, `set`) and `(` - Keep the position of `)` on a new line for a multiline command - Always Use lowercase cmake builtin commands --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 09:48:19 +00:00