deepseek-ai/3FS
1
0
Fork 0
mirror of https://github.com/deepseek-ai/3FS.git synced 2026-11-05 00:47:47 +00:00
Code Issues 166 Projects Packages Wiki Activity

[PR #130] [MERGED] Deprecate usage of some functions in boost #301

New issue
Closed
opened 2026-10-26 09:48:27 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 09:48:27 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/130
Author: @symious
Created: 3/8/2025
Status: ✅ Merged
Merged: 3/8/2025
Merged by: @SF-Zhou

Base: main ← Head: save_and_load

📝 Commits (4)

  • 7b0fd14 Deprecate usage of boost::filesystem::load_string_file and save_string_file
  • a3dd1b9 some other deperated functions
  • 4f325a2 remove complete()
  • 55f6518 normal, save, load

📊 Changes

5 files changed (+38 additions, -17 deletions)

View changed files

📝 benchmarks/storage_bench/StorageBench.h (+16 -6)
📝 src/common/utils/FileUtils.cc (+15 -4)
📝 src/fuse/FuseOps.cc (+1 -1)
📝 tests/meta/TestCommon.cc (+3 -3)
📝 tests/meta/store/ops/TestResolve.cc (+3 -3)

📄 Description

We met the following error while building 3FS.

/home/symious/testground/3fs/3fs/src/common/utils/FileUtils.cc:9:24: error: 'load_string_file' is deprecated: Use file IO streams instead [-Werror,-Wdeprecated-declarations]
    boost::filesystem::load_string_file(path, output);
                       ^
/usr/include/boost/filesystem/string_file.hpp:49:1: note: 'load_string_file' has been explicitly marked deprecated here
BOOST_FILESYSTEM_DETAIL_DEPRECATED("Use file IO streams instead")
^
/usr/include/boost/filesystem/config.hpp:73:49: note: expanded from macro 'BOOST_FILESYSTEM_DETAIL_DEPRECATED'
#define BOOST_FILESYSTEM_DETAIL_DEPRECATED(msg) BOOST_DEPRECATED(msg)
                                                ^
/usr/include/boost/config/compiler/clang.hpp:342:46: note: expanded from macro 'BOOST_DEPRECATED'
#define BOOST_DEPRECATED(msg) __attribute__((deprecated(msg)))
                                             ^
/home/symious/testground/3fs/3fs/src/common/utils/FileUtils.cc:18:24: error: 'save_string_file' is deprecated: Use file IO streams instead [-Werror,-Wdeprecated-declarations]
    boost::filesystem::save_string_file(path, content);
                       ^
/usr/include/boost/filesystem/string_file.hpp:37:1: note: 'save_string_file' has been explicitly marked deprecated here
BOOST_FILESYSTEM_DETAIL_DEPRECATED("Use file IO streams instead")
^
/usr/include/boost/filesystem/config.hpp:73:49: note: expanded from macro 'BOOST_FILESYSTEM_DETAIL_DEPRECATED'
#define BOOST_FILESYSTEM_DETAIL_DEPRECATED(msg) BOOST_DEPRECATED(msg)
                                                ^
/usr/include/boost/config/compiler/clang.hpp:342:46: note: expanded from macro 'BOOST_DEPRECATED'
#define BOOST_DEPRECATED(msg) __attribute__((deprecated(msg)))

The root cause is it's using the deprecated method of "boost::filesystem::load_string_file" and "boost::filesystem::save_string_file" (since Boost 1.76+).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/130 **Author:** [@symious](https://github.com/symious) **Created:** 3/8/2025 **Status:** ✅ Merged **Merged:** 3/8/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `save_and_load` --- ### 📝 Commits (4) - [`7b0fd14`](https://github.com/deepseek-ai/3FS/commit/7b0fd141d633988fb500b8f2d34f250d59d0bdd3) Deprecate usage of boost::filesystem::load_string_file and save_string_file - [`a3dd1b9`](https://github.com/deepseek-ai/3FS/commit/a3dd1b9d25c100e75c3b589bfd370f79701e75da) some other deperated functions - [`4f325a2`](https://github.com/deepseek-ai/3FS/commit/4f325a2fd352b3484bb03244c98f490d5d131c79) remove complete() - [`55f6518`](https://github.com/deepseek-ai/3FS/commit/55f6518fc9dee91ee3bbbac3b0150457664f4785) normal, save, load ### 📊 Changes **5 files changed** (+38 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `benchmarks/storage_bench/StorageBench.h` (+16 -6) 📝 `src/common/utils/FileUtils.cc` (+15 -4) 📝 `src/fuse/FuseOps.cc` (+1 -1) 📝 `tests/meta/TestCommon.cc` (+3 -3) 📝 `tests/meta/store/ops/TestResolve.cc` (+3 -3) </details> ### 📄 Description We met the following error while building 3FS. ``` /home/symious/testground/3fs/3fs/src/common/utils/FileUtils.cc:9:24: error: 'load_string_file' is deprecated: Use file IO streams instead [-Werror,-Wdeprecated-declarations] boost::filesystem::load_string_file(path, output); ^ /usr/include/boost/filesystem/string_file.hpp:49:1: note: 'load_string_file' has been explicitly marked deprecated here BOOST_FILESYSTEM_DETAIL_DEPRECATED("Use file IO streams instead") ^ /usr/include/boost/filesystem/config.hpp:73:49: note: expanded from macro 'BOOST_FILESYSTEM_DETAIL_DEPRECATED' #define BOOST_FILESYSTEM_DETAIL_DEPRECATED(msg) BOOST_DEPRECATED(msg) ^ /usr/include/boost/config/compiler/clang.hpp:342:46: note: expanded from macro 'BOOST_DEPRECATED' #define BOOST_DEPRECATED(msg) __attribute__((deprecated(msg))) ^ /home/symious/testground/3fs/3fs/src/common/utils/FileUtils.cc:18:24: error: 'save_string_file' is deprecated: Use file IO streams instead [-Werror,-Wdeprecated-declarations] boost::filesystem::save_string_file(path, content); ^ /usr/include/boost/filesystem/string_file.hpp:37:1: note: 'save_string_file' has been explicitly marked deprecated here BOOST_FILESYSTEM_DETAIL_DEPRECATED("Use file IO streams instead") ^ /usr/include/boost/filesystem/config.hpp:73:49: note: expanded from macro 'BOOST_FILESYSTEM_DETAIL_DEPRECATED' #define BOOST_FILESYSTEM_DETAIL_DEPRECATED(msg) BOOST_DEPRECATED(msg) ^ /usr/include/boost/config/compiler/clang.hpp:342:46: note: expanded from macro 'BOOST_DEPRECATED' #define BOOST_DEPRECATED(msg) __attribute__((deprecated(msg))) ``` The root cause is it's using the deprecated method of "boost::filesystem::load_string_file" and "boost::filesystem::save_string_file" (since Boost 1.76+). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 09:48:27 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
SF-Zhou-patch-1
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/3FS#301
No description provided.