[PR #145] cli: reuse env KVEngine in dump-* #310

Open
opened 2026-10-26 09:48:32 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/145
Author: @huww98
Created: 3/11/2025
Status: 🔄 Open

Base: main ← Head: dump-fdb


📝 Commits (1)

  • e26f5a9 cli: reuse env KVEngine in dump-*

📊 Changes

8 files changed (+17 additions, -154 deletions)

View changed files

📝 src/client/cli/admin/DumpDirEntries.cc (+4 -7)
📝 src/client/cli/admin/DumpDirEntries.h (+2 -1)
📝 src/client/cli/admin/DumpInodes.cc (+4 -7)
📝 src/client/cli/admin/DumpInodes.h (+2 -1)
📝 src/client/cli/admin/RemoveChunks.cc (+2 -3)
📝 src/meta/event/Scan.cc (+2 -22)
📝 src/meta/event/Scan.h (+1 -5)
📝 tests/meta/event/TestScan.cc (+0 -108)

📄 Description

This allows us to issue multiple command in one process. (runNetwork can only be invoked once in a process) The --fdb-cluster-file flag is removed to reuse the fdb config from config file.

Resolve the SIGFAULT if the specified fdb_cluster_file from flag does not exist.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/145 **Author:** [@huww98](https://github.com/huww98) **Created:** 3/11/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `dump-fdb` --- ### 📝 Commits (1) - [`e26f5a9`](https://github.com/deepseek-ai/3FS/commit/e26f5a901ad2e7c2f38ba898bb848f6874320325) cli: reuse env KVEngine in dump-* ### 📊 Changes **8 files changed** (+17 additions, -154 deletions) <details> <summary>View changed files</summary> 📝 `src/client/cli/admin/DumpDirEntries.cc` (+4 -7) 📝 `src/client/cli/admin/DumpDirEntries.h` (+2 -1) 📝 `src/client/cli/admin/DumpInodes.cc` (+4 -7) 📝 `src/client/cli/admin/DumpInodes.h` (+2 -1) 📝 `src/client/cli/admin/RemoveChunks.cc` (+2 -3) 📝 `src/meta/event/Scan.cc` (+2 -22) 📝 `src/meta/event/Scan.h` (+1 -5) 📝 `tests/meta/event/TestScan.cc` (+0 -108) </details> ### 📄 Description This allows us to issue multiple command in one process. (runNetwork can only be invoked once in a process) The --fdb-cluster-file flag is removed to reuse the fdb config from config file. Resolve the SIGFAULT if the specified fdb_cluster_file from flag does not exist. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/3FS#310
No description provided.