[PR #256] [MERGED] Fix index out of bounds issue in batch_remove #344

Closed
opened 2026-10-26 09:48:53 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/256
Author: @SF-Zhou
Created: 4/24/2025
Status: ✅ Merged
Merged: 4/24/2025
Merged by: @SF-Zhou

Base: main ← Head: dev


📝 Commits (1)

  • d924cff Fix index out of bounds issue in batch_remove

📊 Changes

1 file changed (+8 additions, -8 deletions)

View changed files

📝 src/storage/chunk_engine/src/core/engine.rs (+8 -8)

📄 Description

When the write batch size exceeds the batch size, the current chunk ID has not been committed to the meta store. The meta cache should not delete the current chunk ID in this scenario. This PR fixes the issue.

See also #238 and #252.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/256 **Author:** [@SF-Zhou](https://github.com/SF-Zhou) **Created:** 4/24/2025 **Status:** ✅ Merged **Merged:** 4/24/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `dev` --- ### 📝 Commits (1) - [`d924cff`](https://github.com/deepseek-ai/3FS/commit/d924cff8319a5f8ae440369b385e79289dc9d64e) Fix index out of bounds issue in batch_remove ### 📊 Changes **1 file changed** (+8 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/storage/chunk_engine/src/core/engine.rs` (+8 -8) </details> ### 📄 Description When the write batch size exceeds the batch size, the current chunk ID has not been committed to the meta store. The meta cache should not delete the current chunk ID in this scenario. This PR fixes the issue. See also #238 and #252. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 09:48:53 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/3FS#344
No description provided.