class to avoid 'ibdev2netdev' dependency. #370

New issue

Closed

opened 2026-10-26 09:49:14 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 09:49:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/317
Author: @SimonCqk
Created: 7/25/2025
Status: ✅ Merged
Merged: 7/28/2025
Merged by: @SF-Zhou

Base: main ← Head: main

📝 Commits (1)

5928f41 feat(rdma): parse ibdev2netdev from /sys/class to avoid 'ibdev2netdev' dependency.

📊 Changes

1 file changed (+124 additions, -37 deletions)

View changed files

📝 src/common/net/ib/IBDevice.cc (+124 -37)

📄 Description

The previous implementation relied on executing /usr/sbin/ibdev2netdev via a subprocess to map InfiniBand devices to their corresponding network interfaces. This approach has several problems:

It depends on the ibdev2netdev tool being present in the execution environment, which is not guaranteed, especially in minimal containers.
It may fail in environments with restricted exec permissions.
Forking a new process for device discovery is inefficient.

The new implementation queries the sysfs filesystem directly at /sys/class/infiniband to discover the mapping.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/317 **Author:** [@SimonCqk](https://github.com/SimonCqk) **Created:** 7/25/2025 **Status:** ✅ Merged **Merged:** 7/28/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`5928f41`](https://github.com/deepseek-ai/3FS/commit/5928f4116f5657e3107efd9382558b048dbe2ec3) feat(rdma): parse ibdev2netdev from /sys/class to avoid 'ibdev2netdev' dependency. ### 📊 Changes **1 file changed** (+124 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `src/common/net/ib/IBDevice.cc` (+124 -37) </details> ### 📄 Description The previous implementation relied on executing /usr/sbin/ibdev2netdev via a subprocess to map InfiniBand devices to their corresponding network interfaces. This approach has several problems: - It depends on the ibdev2netdev tool being present in the execution environment, which is not guaranteed, especially in minimal containers. - It may fail in environments with restricted exec permissions. - Forking a new process for device discovery is inefficient. The new implementation queries the sysfs filesystem directly at /sys/class/infiniband to discover the mapping. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 09:49:14 +00:00