[PR #329] [MERGED] fix potential inconsistency in commit chunk(s) #374

New issue

Closed

opened 2026-10-26 09:49:20 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 09:49:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/329
Author: @SF-Zhou
Created: 8/22/2025
Status: ✅ Merged
Merged: 8/22/2025
Merged by: @SF-Zhou

Base: main ← Head: fix-inconsistency-in-commit-chunk

📝 Commits (1)

fbb7e67 fix potential inconsistency in commit chunk(s)

📊 Changes

2 files changed (+23 additions, -4 deletions)

View changed files

📝 src/storage/chunk_engine/src/core/engine.rs (+18 -4)
📝 src/storage/chunk_engine/src/meta/meta_store.rs (+5 -0)

📄 Description

When performing deletion in commit_chunk, the original chunk may have been relocated by the background compact_groups. In this case, the latest chunk location should be obtained after locking to proceed with the commit. This PR fixes this issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/329 **Author:** [@SF-Zhou](https://github.com/SF-Zhou) **Created:** 8/22/2025 **Status:** ✅ Merged **Merged:** 8/22/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `fix-inconsistency-in-commit-chunk` --- ### 📝 Commits (1) - [`fbb7e67`](https://github.com/deepseek-ai/3FS/commit/fbb7e671505da1a7cfcb5a1d1c64698325a736af) fix potential inconsistency in commit chunk(s) ### 📊 Changes **2 files changed** (+23 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/storage/chunk_engine/src/core/engine.rs` (+18 -4) 📝 `src/storage/chunk_engine/src/meta/meta_store.rs` (+5 -0) </details> ### 📄 Description When performing deletion in commit_chunk, the original chunk may have been relocated by the background `compact_groups`. In this case, the latest chunk location should be obtained after locking to proceed with the commit. This PR fixes this issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 09:49:21 +00:00