mirror of
https://github.com/deepseek-ai/3FS.git
synced 2026-11-05 00:47:47 +00:00
[PR #333] [MERGED] Refine(IB): ib connect using 1byte probe msg instead of empty payload. #376
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
deepseek-ai/3FS#376
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/deepseek-ai/3FS/pull/333
Author: @SimonCqk
Created: 8/29/2025
Status: ✅ Merged
Merged: 1/22/2026
Merged by: @yiyuanliu
Base:
main← Head:main📝 Commits (3)
abee2efrefine(IB): ib connect using 1byte probe msg instead of empty payload.2b55e1fApply suggestion from @Copilot17134e5Fix(IB): use immediate message for backward-compatible connect probe.📊 Changes
3 files changed (+32 additions, -8 deletions)
View changed files
📝
src/common/net/ib/IBConnect.cc(+5 -7)📝
src/common/net/ib/IBSocket.cc(+26 -1)📝
src/common/net/ib/IBSocket.h(+1 -0)📄 Description
Fix #320
We observed that RDMA connections consistently fail between different VMs. However, RDMA communication works when performed on the same host (loopback through the same physical NIC). After adding extensive debug logging, we traced the problem to the connection setup phase. It appears that the transport layer in these specific virtualized environments(e.g. GCP) silently drops empty (0-byte) RDMA packets, in the current 3FS implementation, the IBConnect class sends a 0-byte event to notify the peer as part of the connection handshake. This 0-byte packet is the one being dropped, and as a test, we modified the implementation to send a 1-byte event instead of a 0-byte one.
With this change, the RDMA connection is established successfully across different VMs, and the system works as expected in both native IB bare-metal environment and cloud-vendor virtualized RDMA environment.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.