[PR #356] [MERGED] Fix transport leak caused by one-shot clients #385

New issue

Closed

opened 2026-10-26 09:49:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 09:49:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/356
Author: @SF-Zhou
Created: 10/24/2025
Status: ✅ Merged
Merged: 10/24/2025
Merged by: @SF-Zhou

Base: main ← Head: dev

📝 Commits (1)

427d572 Fix transport leak caused by one-shot clients

📊 Changes

1 file changed (+14 additions, -3 deletions)

View changed files

📝 src/common/net/IOWorker.cc (+14 -3)

📄 Description

When the client sends a request and exits quickly, the server successfully processes the request after adding the connection to the event loop and triggers the removal of the connection. However, at this point, the connection does not yet exist in the transport pool, causing the removal to fail. This subsequently leads to the connection being added to the transport pool and results in a leak. This MR fixes the issue. Currently, it is observed that UNIX domain socket connections are the most affected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/356 **Author:** [@SF-Zhou](https://github.com/SF-Zhou) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@SF-Zhou](https://github.com/SF-Zhou) **Base:** `main` ← **Head:** `dev` --- ### 📝 Commits (1) - [`427d572`](https://github.com/deepseek-ai/3FS/commit/427d5722b166d54b412f54f60e59b3c64aa69c16) Fix transport leak caused by one-shot clients ### 📊 Changes **1 file changed** (+14 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/common/net/IOWorker.cc` (+14 -3) </details> ### 📄 Description When the client sends a request and exits quickly, the server successfully processes the request after adding the connection to the event loop and triggers the removal of the connection. However, at this point, the connection does not yet exist in the transport pool, causing the removal to fail. This subsequently leads to the connection being added to the transport pool and results in a leak. This MR fixes the issue. Currently, it is observed that UNIX domain socket connections are the most affected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 09:49:35 +00:00