[PR #372] [CLOSED] fix: TCP connection leak and metric overflow (#365, #366) #395

New issue

Closed

opened 2026-10-26 09:49:50 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 09:49:50 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/372
Author: @yurekami
Created: 12/29/2025
Status: ❌ Closed

Base: main ← Head: fix/tcp-connection-leak-and-metric

📝 Commits (2)

b250b38 fix(io): Add robust symlink cleanup to prevent resource leakage
7bbb48e fix: TCP connection leak and metric overflow (#365, #366)

📊 Changes

3 files changed (+111 additions, -2 deletions)

View changed files

📝 hf3fs_fuse/io.py (+106 -1)
📝 src/common/net/ServiceGroup.cc (+2 -0)
📝 src/common/net/TransportPool.cc (+3 -1)

📄 Description

Summary

Fix TCP connection leak (#365): Add TCP connection cleanup in checkConnectionsRegularly()
Fix metric overflow (#366): Increment connectedCount when creating new outgoing connections

Changes

ServiceGroup.cc: Add TCP connection cleanup alongside RDMA in checkConnectionsRegularly()
TransportPool.cc: Increment connectedCount when creating new connections to match decrement in remove()

Test plan

Verify idle TCP connections are properly released when reducing max_connections
Verify common.net.connected_count metric doesn't overflow

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/372 **Author:** [@yurekami](https://github.com/yurekami) **Created:** 12/29/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/tcp-connection-leak-and-metric` --- ### 📝 Commits (2) - [`b250b38`](https://github.com/deepseek-ai/3FS/commit/b250b38282e544ffba7b3800a9ec9238baacd01d) fix(io): Add robust symlink cleanup to prevent resource leakage - [`7bbb48e`](https://github.com/deepseek-ai/3FS/commit/7bbb48eef80751f4fa4ac5ef75984969101cb2d4) fix: TCP connection leak and metric overflow (#365, #366) ### 📊 Changes **3 files changed** (+111 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `hf3fs_fuse/io.py` (+106 -1) 📝 `src/common/net/ServiceGroup.cc` (+2 -0) 📝 `src/common/net/TransportPool.cc` (+3 -1) </details> ### 📄 Description ## Summary - Fix TCP connection leak (#365): Add TCP connection cleanup in `checkConnectionsRegularly()` - Fix metric overflow (#366): Increment `connectedCount` when creating new outgoing connections ## Changes 1. **ServiceGroup.cc**: Add TCP connection cleanup alongside RDMA in `checkConnectionsRegularly()` 2. **TransportPool.cc**: Increment `connectedCount` when creating new connections to match decrement in `remove()` ## Test plan - [x] Verify idle TCP connections are properly released when reducing `max_connections` - [x] Verify `common.net.connected_count` metric doesn't overflow 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 09:49:50 +00:00