deepseek-ai/3FS
1
0
Fork 0
mirror of https://github.com/deepseek-ai/3FS.git synced 2026-11-05 00:47:47 +00:00
Code Issues 166 Projects Packages Wiki Activity

[PR #404] [MERGED] fix: correct timeout check logic for IoRing::jobsToProc #418

New issue
Closed
opened 2026-10-26 09:50:05 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 09:50:05 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/404
Author: @dxlog0
Created: 3/28/2026
Status: ✅ Merged
Merged: 3/30/2026
Merged by: @KuribohG

Base: main ← Head: user/zdx/fix_bug

📝 Commits (1)

  • d308039 fix(IoRing): correct timeout check logic for batch processing

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/fuse/IoRing.cc (+1 -1)

📄 Description

Fix a logic error in IoRing's timeout check mechanism. The issue was that lastCheck_ was being assigned at the same time as now, making the !lastCheck_ condition always false. This prevented the timeout waiting logic from working correctly when ioDepth is negative.

The fix separates the time acquisition from the state assignment, ensuring that the first-time check works properly and the timeout mechanism functions as intended.

This change affects the getJobs() method in src/fuse/IoRing.cc, specifically the batch processing logic when ioDepth is negative.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/404 **Author:** [@dxlog0](https://github.com/dxlog0) **Created:** 3/28/2026 **Status:** ✅ Merged **Merged:** 3/30/2026 **Merged by:** [@KuribohG](https://github.com/KuribohG) **Base:** `main` ← **Head:** `user/zdx/fix_bug` --- ### 📝 Commits (1) - [`d308039`](https://github.com/deepseek-ai/3FS/commit/d30803977e746e5628306f4cf4c0bf607ec38c8f) fix(IoRing): correct timeout check logic for batch processing ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/fuse/IoRing.cc` (+1 -1) </details> ### 📄 Description Fix a logic error in IoRing's timeout check mechanism. The issue was that `lastCheck_` was being assigned at the same time as `now`, making the `!lastCheck_` condition always false. This prevented the timeout waiting logic from working correctly when `ioDepth` is negative. The fix separates the time acquisition from the state assignment, ensuring that the first-time check works properly and the timeout mechanism functions as intended. This change affects the `getJobs()` method in `src/fuse/IoRing.cc`, specifically the batch processing logic when `ioDepth` is negative. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 09:50:05 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
SF-Zhou-patch-1
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/3FS#418
No description provided.