[PR #420] fix(packaging): remove git dependency from package version #425

New issue

Open

opened 2026-10-26 09:50:09 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 09:50:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/3FS/pull/420
Author: @030611
Created: 8/10/2026
Status: 🔄 Open

Base: main ← Head: fix/packaging-sdist-343

📝 Commits (1)

95f4f2d fix(packaging): avoid git dependency in source distributions

📊 Changes

2 files changed (+62 additions, -3 deletions)

View changed files

📝 setup.py (+1 -3)
➕ tests/test_setup.py (+61 -0)

📄 Description

Addresses #343.

The generated source distribution runs git rev-parse from setup.py, but an unpacked sdist has no .git directory. That makes even package metadata commands fail before the native extension build starts.

This removes the unused revision suffix and keeps the package version at 1.2.9, matching the published sdist metadata. The regression test builds an sdist from a temporary Git checkout, extracts it outside Git, and verifies that setup.py --version and PKG-INFO both report 1.2.9.

This intentionally makes source-checkout metadata match the published version instead of adding a local +<sha> suffix.

Tested with:

pytest tests/test_setup.py (1 passed)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/3FS/pull/420 **Author:** [@030611](https://github.com/030611) **Created:** 8/10/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/packaging-sdist-343` --- ### 📝 Commits (1) - [`95f4f2d`](https://github.com/deepseek-ai/3FS/commit/95f4f2ddc4c5cd0207d99925974baa56cbc47514) fix(packaging): avoid git dependency in source distributions ### 📊 Changes **2 files changed** (+62 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `setup.py` (+1 -3) ➕ `tests/test_setup.py` (+61 -0) </details> ### 📄 Description Addresses #343. The generated source distribution runs `git rev-parse` from `setup.py`, but an unpacked sdist has no `.git` directory. That makes even package metadata commands fail before the native extension build starts. This removes the unused revision suffix and keeps the package version at `1.2.9`, matching the published sdist metadata. The regression test builds an sdist from a temporary Git checkout, extracts it outside Git, and verifies that `setup.py --version` and `PKG-INFO` both report `1.2.9`. This intentionally makes source-checkout metadata match the published version instead of adding a local `+<sha>` suffix. Tested with: - `pytest tests/test_setup.py` (1 passed) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-26 09:50:09 +00:00

bsakaguchi referenced this issue

2026-10-26 09:50:11 +00:00

[PR #425] fix(fuse): clean up partial read setup #428