[GH-ISSUE #120] [low latency] why Stronger acquire scope for low-latency kernels ? #108

Closed
opened 2026-10-26 09:54:25 +00:00 by bsakaguchi · 2 comments
Owner

Originally created by @elevenxiang on GitHub (Apr 14, 2025).
Original GitHub issue: https://github.com/deepseek-ai/DeepEP/issues/120

Hi

why need change Stronger acquire scope for low-latency kernels ?

does it have potential data mismatch issue ?

Thanks

Originally created by @elevenxiang on GitHub (Apr 14, 2025). Original GitHub issue: https://github.com/deepseek-ai/DeepEP/issues/120 Hi why need change Stronger acquire scope for low-latency kernels ? does it have potential data mismatch issue ? Thanks
Author
Owner

@LyricZhao commented on GitHub (Apr 14, 2025):

Do you mean while ((num_recv_tokens = ld_acquire_sys_global(rdma_recv_count + local_expert_idx * num_ranks + src_rank)) == 0);?

Because the network card is belonged to the system scope. This is more likely to be "semantically correct", changing it to GPU scope works as well.

<!-- gh-comment-id:2800784288 --> @LyricZhao commented on GitHub (Apr 14, 2025): Do you mean `while ((num_recv_tokens = ld_acquire_sys_global(rdma_recv_count + local_expert_idx * num_ranks + src_rank)) == 0);`? Because the network card is belonged to the system scope. This is more likely to be "semantically correct", changing it to GPU scope works as well.
Author
Owner

@elevenxiang commented on GitHub (Apr 15, 2025):

Do you mean while ((num_recv_tokens = ld_acquire_sys_global(rdma_recv_count + local_expert_idx * num_ranks + src_rank)) == 0);?

Because the network card is belonged to the system scope. This is more likely to be "semantically correct", changing it to GPU scope works as well.

ok, thanks

<!-- gh-comment-id:2803532514 --> @elevenxiang commented on GitHub (Apr 15, 2025): > Do you mean `while ((num_recv_tokens = ld_acquire_sys_global(rdma_recv_count + local_expert_idx * num_ranks + src_rank)) == 0);`? > > Because the network card is belonged to the system scope. This is more likely to be "semantically correct", changing it to GPU scope works as well. ok, thanks
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepEP#108
No description provided.