mirror of
https://github.com/deepseek-ai/DeepEP.git
synced 2026-11-05 00:47:32 +00:00
[GH-ISSUE #15] Test test_low_latency.py failed #14
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
deepseek-ai/DeepEP#14
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Nekofish-L on GitHub (Feb 25, 2025).
Original GitHub issue: https://github.com/deepseek-ai/DeepEP/issues/15
I encountered an issue while running the test
python test_low_latency.py. The test is failing with the following error:However, another related test
tests/test_intranode.pyruns successfully and produces the expected output.Environment:
@haswelliris commented on GitHub (Feb 25, 2025):
Please provide additional information, including:
ibstatus.nvidia-smi topo -mto retrieve this information.Furthermore, please share the results of the following reports, if available:
nvshmem perftestReport:Alternatively, you can simply provide the output of the command:
@LyricZhao commented on GitHub (Feb 25, 2025):
There is a line
num_tokens, hidden, num_topk, num_experts = 128, 7168, 8, 288in the test, indicating the SM used isnum_experts / 3 = 96(refer tohttps://github.com/deepseek-ai/DeepEP/blob/main/csrc/kernels/internode_ll.cu#L305C26-L305C63), which exceeds the H20 SM count.You can try to reduce the number of experts.
@LyricZhao commented on GitHub (Feb 25, 2025):
We may add H20 compatible changes later.
@MengYu10151 commented on GitHub (Mar 10, 2025):
Hi Lyric, in addition to reducing the number of experts, is it possible to enable 288 experts by changing other parameters? and I also wonder if the H20 support change will be launched soon? Thanks!
@LyricZhao commented on GitHub (Mar 10, 2025):
It is possible, and for an easier solution (I will update the mainstream later), you can simply change (2 places, both dispatch and combine)
into
and remove
EP_HOST_ASSERT(cell_div(static_cast<int>(hidden * 2 / sizeof(int4)), 32 * (num_warps - 1)) <= 2);.I don't have H20 for testing, if the performance is not good, please report and file an issue :)
@alpha-baby commented on GitHub (Mar 24, 2025):
In my H20 machine, I used a single server to run the test : tests/test_low_latency.py.
result:
but the program for testing will SIGSEGV.
log:
gdb debug coredump file:
Is this because verbs has a bug?
@sphish commented on GitHub (Apr 3, 2025):
@alpha-baby I believe verbs is a well-tested library and likely doesn't contain bugs in this case. The issue might be caused by something else. For example, is
nvshmem_finalizecalled twice in your test?@alpha-baby commented on GitHub (Apr 11, 2025):
Can we make this variable directly configurable? Then, users are recommended how to configure different types of GPUs, and users can also customize them.
@LyricZhao commented on GitHub (Apr 11, 2025):
OK, will do it later.
@whybeyoung commented on GitHub (Apr 16, 2025):
is there any update on this ? i can't find this line. @LyricZhao
@LyricZhao commented on GitHub (Apr 16, 2025):
Yep, I removed it. No more checks, performace may degrade a little bit, but not a big deal.
@whybeyoung commented on GitHub (Apr 17, 2025):
tested. it's ok after do that in h20 node.
@liusy58 commented on GitHub (Apr 27, 2025):
@LyricZhao Not sure why we also need to change
kNumWarpsPerGroup. Could you please give me an explanation?@LyricZhao commented on GitHub (Apr 27, 2025):
It is related to performance, see https://github.com/deepseek-ai/DeepEP/issues/63#issuecomment-2712529850 for more discussion.
@LyricZhao commented on GitHub (Jun 16, 2025):
Fixed in #213, close it now.