[GH-ISSUE #267] apply third-party/nvshmem.patch failed #197

Closed
opened 2026-10-26 09:56:24 +00:00 by bsakaguchi · 5 comments
Owner

Originally created by @star92016 on GitHub (Jun 30, 2025).
Original GitHub issue: https://github.com/deepseek-ai/DeepEP/issues/267

The patch has expired, maybe upstream in-place update.

git apply /path/to/deep_ep/dir/third-party/nvshmem.patch
error: patch failed: src/modules/transport/ibgda/ibgda.cpp:2936
error: src/modules/transport/ibgda/ibgda.cpp: patch does not apply
error: patch failed: src/modules/transport/common/transport_ib_common.cpp:26
error: src/modules/transport/common/transport_ib_common.cpp: patch does not apply
error: patch failed: src/modules/transport/ibgda/ibgda.cpp:406
error: src/modules/transport/ibgda/ibgda.cpp: patch does not apply

See third-party

Maybe NVIDIA NVSHMEM OPEN SOURCE PACKAGES is update?

Originally created by @star92016 on GitHub (Jun 30, 2025). Original GitHub issue: https://github.com/deepseek-ai/DeepEP/issues/267 The patch has expired, maybe upstream in-place update. ```bash git apply /path/to/deep_ep/dir/third-party/nvshmem.patch error: patch failed: src/modules/transport/ibgda/ibgda.cpp:2936 error: src/modules/transport/ibgda/ibgda.cpp: patch does not apply error: patch failed: src/modules/transport/common/transport_ib_common.cpp:26 error: src/modules/transport/common/transport_ib_common.cpp: patch does not apply error: patch failed: src/modules/transport/ibgda/ibgda.cpp:406 error: src/modules/transport/ibgda/ibgda.cpp: patch does not apply ``` See [third-party](https://github.com/deepseek-ai/DeepEP/blob/main/third-party/README.md) Maybe [NVIDIA NVSHMEM OPEN SOURCE PACKAGES](https://developer.nvidia.com/downloads/assets/secure/nvshmem/nvshmem_src_3.2.5-1.txz) is update?
Author
Owner

@sphish commented on GitHub (Jun 30, 2025):

Yes, the NVSHMEM src linked here has been updated to v3.3.9 and this patch is expired. I will update the patch soon; perhaps we may no longer need it :)

<!-- gh-comment-id:3017826058 --> @sphish commented on GitHub (Jun 30, 2025): Yes, the NVSHMEM src linked here has been updated to v3.3.9 and this patch is expired. I will update the patch soon; perhaps we may no longer need it :)
Author
Owner

@Skylion007 commented on GitHub (Jun 30, 2025):

The versioned URL directs to the newer nvshmem library? Is this an error on Nvidia's side. Any ideas @eqy?

<!-- gh-comment-id:3019824605 --> @Skylion007 commented on GitHub (Jun 30, 2025): The versioned URL directs to the newer nvshmem library? Is this an error on Nvidia's side. Any ideas @eqy?
Author
Owner

@Skylion007 commented on GitHub (Jul 1, 2025):

@sphish @star92016 Great news, Nvidia fixed the versioned URL to point to the old version.

<!-- gh-comment-id:3024600180 --> @Skylion007 commented on GitHub (Jul 1, 2025): @sphish @star92016 Great news, Nvidia fixed the versioned URL to point to the old version.
Author
Owner

@mgw2168-1 commented on GitHub (Jul 2, 2025):

same issue

<!-- gh-comment-id:3026607535 --> @mgw2168-1 commented on GitHub (Jul 2, 2025): same issue
Author
Owner

@sphish commented on GitHub (Jul 11, 2025):

Yes, the NVSHMEM src linked here has been updated to v3.3.9 and this patch is expired. I will update the patch soon; perhaps we may no longer need it :)

Hi there, based on my testing, for the NVSHMEM v3.3.9, it is no longer necessary to apply the patch to achieve optimal performance. github.com/deepseek-ai/DeepEP@b0f13ef7c4

<!-- gh-comment-id:3060668884 --> @sphish commented on GitHub (Jul 11, 2025): > Yes, the NVSHMEM src linked here has been updated to v3.3.9 and this patch is expired. I will update the patch soon; perhaps we may no longer need it :) Hi there, based on my testing, for the NVSHMEM v3.3.9, it is no longer necessary to apply the patch to achieve optimal performance. https://github.com/deepseek-ai/DeepEP/commit/b0f13ef7c410c4da3c62d03a1650603a005fbb45
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepEP#197
No description provided.