[PR #523] Fix combine correctness check in test_internode.py with correct eps #609

New issue

Open

opened 2026-10-27 21:04:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:04:30 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepEP/pull/523
Author: @hexclover
Created: 12/18/2025
Status: 🔄 Open

Base: main ← Head: patch-1

📝 Commits (1)

e97bc08 Use correct float eps for combine check in test_internode.py

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 tests/test_internode.py (+1 -1)

📄 Description

In test_internode.py the results of combine is checked against the reference. The tolerance is set as follows:

assert calc_diff(check_x, ref_x) < 5e-4 if current_x is x_pure_rand_e4m3 else 5e-6

However, this actually gets parsed as

assert (calc_diff(check_x, ref_x) < 5e-4) if (current_x is x_pure_rand_e4m3) else 5e-6

So the cases where x is not x_pure_rand_e4m3 are not checked at all. This PR fix this problem.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepEP/pull/523 **Author:** [@hexclover](https://github.com/hexclover) **Created:** 12/18/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`e97bc08`](https://github.com/deepseek-ai/DeepEP/commit/e97bc08d360001fa112749a4325e59150a3a2b5a) Use correct float eps for combine check in test_internode.py ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/test_internode.py` (+1 -1) </details> ### 📄 Description In `test_internode.py` the results of combine is checked against the reference. The tolerance is set as follows: ```python3 assert calc_diff(check_x, ref_x) < 5e-4 if current_x is x_pure_rand_e4m3 else 5e-6 ``` However, this actually gets parsed as ```python3 assert (calc_diff(check_x, ref_x) < 5e-4) if (current_x is x_pure_rand_e4m3) else 5e-6 ``` So the cases where `x is not x_pure_rand_e4m3` are not checked at all. This PR fix this problem. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-27 21:04:30 +00:00

bsakaguchi referenced this issue

2026-10-27 21:04:58 +00:00

[PR #609] fix: skip self NVLink connection check #582 #660