[PR #697] fix(test): remove dead num_worst_tokens test from internode file #714

New issue

Open

opened 2026-10-27 21:05:31 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:05:31 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepEP/pull/697
Author: @Syan-Lin
Created: 7/24/2026
Status: 🔄 Open

Base: main ← Head: fix-670-num-worst-tokens-internode

📝 Commits (1)

df07e62 fix(test): remove dead num_worst_tokens test from internode file

📊 Changes

1 file changed (+0 additions, -15 deletions)

View changed files

📝 tests/legacy/test_internode.py (+0 -15)

📄 Description

Problem

test_internode.py included a copy-pasted num_worst_tokens != 0
test block from test_intranode.py. This block was dead code —
Buffer::dispatch asserts num_worst_tokens == 0 for multi-RDMA-rank
internode dispatch (legacy.py:378-379), so the test could never run.
When triggered, it crashed the test suite.

Fix

Remove the block entirely from test_internode.py. Coverage is
preserved in test_intranode.py where the feature is supported.

References

Fixes #670
deep_ep/buffers/legacy.py:354-355: "this flag is for intranode only"
docs/legacy.md:172: "this flag is for intranode only"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepEP/pull/697 **Author:** [@Syan-Lin](https://github.com/Syan-Lin) **Created:** 7/24/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-670-num-worst-tokens-internode` --- ### 📝 Commits (1) - [`df07e62`](https://github.com/deepseek-ai/DeepEP/commit/df07e6252668066fd5efe47b7eb011d49ab5b4ab) fix(test): remove dead num_worst_tokens test from internode file ### 📊 Changes **1 file changed** (+0 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `tests/legacy/test_internode.py` (+0 -15) </details> ### 📄 Description ## Problem `test_internode.py` included a copy-pasted `num_worst_tokens != 0` test block from `test_intranode.py`. This block was dead code — `Buffer::dispatch` asserts `num_worst_tokens == 0` for multi-RDMA-rank internode dispatch (`legacy.py:378-379`), so the test could never run. When triggered, it crashed the test suite. ## Fix Remove the block entirely from `test_internode.py`. Coverage is preserved in `test_intranode.py` where the feature is supported. ## References - Fixes #670 - `deep_ep/buffers/legacy.py:354-355`: "this flag is for intranode only" - `docs/legacy.md:172`: "this flag is for intranode only" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-27 21:05:31 +00:00

bsakaguchi referenced this issue

2026-10-27 21:05:40 +00:00

[PR #714] Escape generated build environment metadata #727