[PR #734] bug fix: probe RDMA link rate via sysfs, survive probe failure #740

New issue

Open

opened 2026-10-27 21:05:46 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:05:46 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepEP/pull/734
Author: @Xuan-1998
Created: 8/21/2026
Status: 🔄 Open

Base: main ← Head: envs-sysfs-rdma-probe

📝 Commits (1)

dacd416 envs: probe RDMA link rate via sysfs, survive probe failure

📊 Changes

1 file changed (+75 additions, -6 deletions)

View changed files

📝 deep_ep/utils/envs.py (+75 -6)

📄 Description

get_rdma_gbs() only knew how to ask ibstat for a CA named EP_NIC_NAME (default mlx5_0). EFA devices expose no umad CA, so on EFA hosts the probe returned 0 and get_theoretical_num_sms() divided by it -- any multi-node run without an explicit --num-sms crashed with ZeroDivisionError.

Read /sys/class/infiniband//ports/*/rate first, which works for every verbs provider, and fall back to ibstat for setups whose rate only shows there. When EP_NIC_NAME is unset and the default device is absent, pick the fastest device under /sys/class/infiniband instead of failing; an explicitly named NIC still fails loudly rather than guessing.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepEP/pull/734 **Author:** [@Xuan-1998](https://github.com/Xuan-1998) **Created:** 8/21/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `envs-sysfs-rdma-probe` --- ### 📝 Commits (1) - [`dacd416`](https://github.com/deepseek-ai/DeepEP/commit/dacd416c031d803e71fca9be65f41dcdb5dd30d5) envs: probe RDMA link rate via sysfs, survive probe failure ### 📊 Changes **1 file changed** (+75 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `deep_ep/utils/envs.py` (+75 -6) </details> ### 📄 Description get_rdma_gbs() only knew how to ask ibstat for a CA named EP_NIC_NAME (default mlx5_0). EFA devices expose no umad CA, so on EFA hosts the probe returned 0 and get_theoretical_num_sms() divided by it -- any multi-node run without an explicit --num-sms crashed with ZeroDivisionError. Read /sys/class/infiniband/<nic>/ports/*/rate first, which works for every verbs provider, and fall back to ibstat for setups whose rate only shows there. When EP_NIC_NAME is unset and the default device is absent, pick the fastest device under /sys/class/infiniband instead of failing; an explicitly named NIC still fails loudly rather than guessing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-27 21:05:46 +00:00

bsakaguchi referenced this issue

2026-10-27 21:05:49 +00:00

[PR #740] fix: get_nvlink_gbs may return 0 as a divisor #745