[PR #741] docs: point Development section to develop.sh (fix stale ln -s for V2) #746

Open
opened 2026-10-27 21:05:50 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepEP/pull/741
Author: @pengfaming
Created: 8/28/2026
Status: 🔄 Open

Base: main ← Head: fix/readme-development-ln-s


📝 Commits (1)

  • 07d216a docs: point Development section to develop.sh (fix stale ln -s for V2)

📊 Changes

1 file changed (+2 additions, -4 deletions)

View changed files

📝 README.md (+2 -4)

📄 Description

What

The Development section of the README instructs users to run:

python setup.py build
ln -s build/lib.linux-x86_64-cpython-38/deep_ep_cpp.cpython-38-x86_64-linux-gnu.so

This command is stale. Since the V2 refactor the extension is named deep_ep._C (see setup.py), so build/lib.linux-x86_64-cpython-38/deep_ep_cpp...so no longer exists and the ln -s step fails / links nothing usable.

The repo already ships a correct development script, ./develop.sh, which builds the extension and creates the proper symbolic links for the SO files.

Why

Users following the README's development instructions hit a broken command. Pointing to ./develop.sh gives them the maintained, working path.

How I checked

  • Confirmed the extension is built as deep_ep._C in setup.py (V2 naming).
  • Confirmed develop.sh exists in the repo root and does the build + symlink step.
  • Verified tests/elastic/test_ep.py etc. are still referenced after the change.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepEP/pull/741 **Author:** [@pengfaming](https://github.com/pengfaming) **Created:** 8/28/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/readme-development-ln-s` --- ### 📝 Commits (1) - [`07d216a`](https://github.com/deepseek-ai/DeepEP/commit/07d216a4ddf3b737e4bc7ea598e90a0a7a435e23) docs: point Development section to develop.sh (fix stale ln -s for V2) ### 📊 Changes **1 file changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+2 -4) </details> ### 📄 Description ### What The `Development` section of the README instructs users to run: ``` python setup.py build ln -s build/lib.linux-x86_64-cpython-38/deep_ep_cpp.cpython-38-x86_64-linux-gnu.so ``` This command is stale. Since the V2 refactor the extension is named `deep_ep._C` (see `setup.py`), so `build/lib.linux-x86_64-cpython-38/deep_ep_cpp...so` no longer exists and the `ln -s` step fails / links nothing usable. The repo already ships a correct development script, `./develop.sh`, which builds the extension and creates the proper symbolic links for the SO files. ### Why Users following the README's development instructions hit a broken command. Pointing to `./develop.sh` gives them the maintained, working path. ### How I checked - Confirmed the extension is built as `deep_ep._C` in `setup.py` (V2 naming). - Confirmed `develop.sh` exists in the repo root and does the build + symlink step. - Verified `tests/elastic/test_ep.py` etc. are still referenced after the change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepEP#746
No description provided.