[PR #755] docs: stop pointing the PCIe usage guide at a removed test file #760

New issue

Open

opened 2026-10-27 21:06:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:06:00 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepEP/pull/755
Author: @PerryLink
Created: 9/19/2026
Status: 🔄 Open

Base: hybrid-ep ← Head: docs/pcie-guide-removed-test

📝 Commits (1)

5095870 docs: stop pointing the PCIe usage guide at a removed test file

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 docs/README_PCIe.md (+1 -3)

📄 Description

What

docs/README_PCIe.md refers twice to tests/test_normal_without_nvl.py — in the "New Files" listing and as the Quick Start entry point. It does not exist on this branch:

GET /repos/deepseek-ai/DeepEP/contents/tests/test_normal_without_nvl.py?ref=hybrid-ep → 404

Why

It was added by #375 and removed later. GET /repos/deepseek-ai/DeepEP/compare/476ad704133e04942ce113ec3ffdd028abb2fa5e...hybrid-ep reports removed tests/test_normal_without_nvl.py (+0/-218), and a code search finds nothing: GET /search/code?q=test_normal_without_nvl+repo:deepseek-ai/DeepEP → total_count: 0.

No test on hybrid-ep passes allow_nvlink_for_normal_mode, so there is no like-for-like file to point at. The switch itself is real: a deep_ep.Buffer constructor argument at deep_ep/buffer.py:36, described at line 52 as "whether to use NVLink for normal mode, if False, then use RDMA/PCIe" — contents/deep_ep/buffer.py?ref=hybrid-ep → 200, blob 88d1b2139310b0762bcdccff474cef0531186cdd. The original sentence never said which value selects PCIe.

Change

 tests/
-└── test_normal_without_nvl.py       # Normal mode w/o NVLink testing

-Refer to tests/test_normal_without_nvl.py, the only change for user to use pcie kernel is to select transport path by setting 'allow_nvlink_for_normal_mode'.
+Refer to deep_ep/buffer.py: the only change for user to use the PCIe kernel is to select the transport path by setting allow_nvlink_for_normal_mode=False when constructing deep_ep.Buffer.


The listing's other two rows, `csrc/kernels/pcie.cu` and `deep_ep/buffer.py`, both exist and are untouched.

## Validation

Documentation only — no runtime change. After the patch every repository path in the file resolves against `hybrid-ep`: `csrc/kernels/pcie.cu` (`522b9613b6dff6c1794c61b79818a3cdd12a4240`) and `deep_ep/buffer.py` (`88d1b2139310b0762bcdccff474cef0531186cdd`).

## Review history

`ds-review-bot` reviewed an earlier revision of this branch, `425f9cee`, before the commit was corrected. Two things were genuinely wrong in that revision and the bot caught both:

1. the commit was built against the wrong tree, so `git show --stat` read `80 files changed, 3 insertions, 32697 deletions` — every file except this document appeared deleted;
2. the edit itself was malformed: the new sentence landed inside the "New Files" code fence and two literal `undefined` strings were committed, leaving the Quick Start body as the text `undefined`.

The branch was then rebuilt from the upstream blob text and force-pushed. The current head is `5095870d` and the diff is **1 file, +1/−3**: the two stale listing rows (`tests/` and its `test_normal_without_nvl.py` child) are deleted with no replacement, and the Quick Start sentence is replaced in place. Verified after the rebuild: 64 lines → 62, exactly 3 removed and 1 added, no `undefined`, both code fences still balance, and all six headings intact.


---

<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepEP/pull/755 **Author:** [@PerryLink](https://github.com/PerryLink) **Created:** 9/19/2026 **Status:** 🔄 Open **Base:** `hybrid-ep` ← **Head:** `docs/pcie-guide-removed-test` --- ### 📝 Commits (1) - [`5095870`](https://github.com/deepseek-ai/DeepEP/commit/5095870d12f0e1c68db3daca705ca5505be21909) docs: stop pointing the PCIe usage guide at a removed test file ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/README_PCIe.md` (+1 -3) </details> ### 📄 Description ## What `docs/README_PCIe.md` refers twice to `tests/test_normal_without_nvl.py` — in the "New Files" listing and as the Quick Start entry point. It does not exist on this branch: - `GET /repos/deepseek-ai/DeepEP/contents/tests/test_normal_without_nvl.py?ref=hybrid-ep` → **404** ## Why It was added by #375 and removed later. `GET /repos/deepseek-ai/DeepEP/compare/476ad704133e04942ce113ec3ffdd028abb2fa5e...hybrid-ep` reports `removed tests/test_normal_without_nvl.py (+0/-218)`, and a code search finds nothing: `GET /search/code?q=test_normal_without_nvl+repo:deepseek-ai/DeepEP` → `total_count: 0`. No test on `hybrid-ep` passes `allow_nvlink_for_normal_mode`, so there is no like-for-like file to point at. The switch itself is real: a `deep_ep.Buffer` constructor argument at `deep_ep/buffer.py:36`, described at line 52 as "whether to use NVLink for normal mode, if False, then use RDMA/PCIe" — `contents/deep_ep/buffer.py?ref=hybrid-ep` → **200**, blob `88d1b2139310b0762bcdccff474cef0531186cdd`. The original sentence never said which value selects PCIe. ## Change ```diff tests/ -└── test_normal_without_nvl.py # Normal mode w/o NVLink testing ``` -Refer to `tests/test_normal_without_nvl.py`, the only change for user to use pcie kernel is to select transport path by setting 'allow_nvlink_for_normal_mode'. +Refer to `deep_ep/buffer.py`: the only change for user to use the PCIe kernel is to select the transport path by setting `allow_nvlink_for_normal_mode=False` when constructing `deep_ep.Buffer`. ``` The listing's other two rows, `csrc/kernels/pcie.cu` and `deep_ep/buffer.py`, both exist and are untouched. ## Validation Documentation only — no runtime change. After the patch every repository path in the file resolves against `hybrid-ep`: `csrc/kernels/pcie.cu` (`522b9613b6dff6c1794c61b79818a3cdd12a4240`) and `deep_ep/buffer.py` (`88d1b2139310b0762bcdccff474cef0531186cdd`). ## Review history `ds-review-bot` reviewed an earlier revision of this branch, `425f9cee`, before the commit was corrected. Two things were genuinely wrong in that revision and the bot caught both: 1. the commit was built against the wrong tree, so `git show --stat` read `80 files changed, 3 insertions, 32697 deletions` — every file except this document appeared deleted; 2. the edit itself was malformed: the new sentence landed inside the "New Files" code fence and two literal `undefined` strings were committed, leaving the Quick Start body as the text `undefined`. The branch was then rebuilt from the upstream blob text and force-pushed. The current head is `5095870d` and the diff is **1 file, +1/−3**: the two stale listing rows (`tests/` and its `test_normal_without_nvl.py` child) are deleted with no replacement, and the Quick Start sentence is replaced in place. Verified after the rebuild: 64 lines → 62, exactly 3 removed and 1 added, no `undefined`, both code fences still balance, and all six headings intact. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-27 21:06:00 +00:00

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

deepseek-ai/DeepEP#760

No description provided.

Rows
Columns