deepseek-ai/DeepEP
1
0
Fork 0
mirror of https://github.com/deepseek-ai/DeepEP.git synced 2026-11-05 00:47:32 +00:00
Code Issues 308 Projects Packages Wiki Activity

[PR #795] fix(build): stop helper scripts after failed commands #790

New issue
Open
opened 2026-10-27 21:06:23 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-27 21:06:23 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepEP/pull/795
Author: @bvolpato
Created: 10/25/2026
Status: 🔄 Open

Base: main ← Head: bvolpato/fail-fast-build-scripts

📝 Commits (1)

  • ea13168 fix(build): stop helper scripts after failed commands

📊 Changes

4 files changed (+83 additions, -0 deletions)

View changed files

📝 build.sh (+2 -0)
📝 develop.sh (+2 -0)
📝 install.sh (+2 -0)
➕ tests/utils/test_build_scripts.py (+77 -0)

📄 Description

Summary

The build helpers finish by changing back to the caller's directory, so a failed build or installation can still return success. install.sh can continue to pip after a failed build, and develop.sh can link an extension left by an incomplete build.

Changes

Stop build.sh, install.sh, and develop.sh when a command fails. Add isolated regression coverage for build failures, installation failures, partial artifacts, and successful runs.

Testing

python tests/utils/test_build_scripts.py passes, including on Python 3.10. The failure cases fail against the current upstream scripts and pass with this change. Shell syntax checks and git diff --check also pass.

The tests use temporary project copies and stub build/install commands. No CUDA build or GPU kernels were run.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepEP/pull/795 **Author:** [@bvolpato](https://github.com/bvolpato) **Created:** 10/25/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `bvolpato/fail-fast-build-scripts` --- ### 📝 Commits (1) - [`ea13168`](https://github.com/deepseek-ai/DeepEP/commit/ea13168e1d30e72696a209d89146a23b2b1513fa) fix(build): stop helper scripts after failed commands ### 📊 Changes **4 files changed** (+83 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `build.sh` (+2 -0) 📝 `develop.sh` (+2 -0) 📝 `install.sh` (+2 -0) ➕ `tests/utils/test_build_scripts.py` (+77 -0) </details> ### 📄 Description ## Summary The build helpers finish by changing back to the caller's directory, so a failed build or installation can still return success. `install.sh` can continue to pip after a failed build, and `develop.sh` can link an extension left by an incomplete build. ## Changes Stop `build.sh`, `install.sh`, and `develop.sh` when a command fails. Add isolated regression coverage for build failures, installation failures, partial artifacts, and successful runs. ## Testing `python tests/utils/test_build_scripts.py` passes, including on Python 3.10. The failure cases fail against the current upstream scripts and pass with this change. Shell syntax checks and `git diff --check` also pass. The tests use temporary project copies and stub build/install commands. No CUDA build or GPU kernels were run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
hybrid-ep
chore/remove-clang-format-yapf
v2.5
nvDev
try-fix-cu128
mori-ep
antgroup-opt
compat-old-torch
add-linter
eager-rdma
v1.2.1
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepEP#790
No description provided.