[GH-ISSUE #88] When should we refresh handle? #80

Closed
opened 2026-10-26 09:53:56 +00:00 by bsakaguchi · 2 comments
Owner

Originally created by @AHEADer on GitHub (Mar 24, 2025).
Original GitHub issue: https://github.com/deepseek-ai/DeepEP/issues/88

I see # NOTES: handle must be refreshed in tests/test_intranode.py, what does it mean? How do we change the handle variable when we have moe computation between dispatch and combine?

Originally created by @AHEADer on GitHub (Mar 24, 2025). Original GitHub issue: https://github.com/deepseek-ai/DeepEP/issues/88 I see `# NOTES: handle must be refreshed` in tests/test_intranode.py, what does it mean? How do we change the handle variable when we have moe computation between dispatch and combine?
Author
Owner

@LyricZhao commented on GitHub (Mar 25, 2025):

Sorry, this is something for earlier version, which will change the handle with every dispatch/combine. Now the handle will never be changed, I will remove these comments. Thanks!

<!-- gh-comment-id:2749801278 --> @LyricZhao commented on GitHub (Mar 25, 2025): Sorry, this is something for earlier version, which will change the handle with every dispatch/combine. Now the handle will never be changed, I will remove these comments. Thanks!
Author
Owner

@LyricZhao commented on GitHub (Mar 25, 2025):

Removed in github.com/deepseek-ai/DeepEP@ae0eafd2be, closing it now, feel free to reopen it if you have other problems.

<!-- gh-comment-id:2749803827 --> @LyricZhao commented on GitHub (Mar 25, 2025): Removed in https://github.com/deepseek-ai/DeepEP/commit/ae0eafd2be0ad471f58f53d1b029b9fd6602dd1e, closing it now, feel free to reopen it if you have other problems.
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepEP#80
No description provided.