deepseek-ai/DeepGEMM
1
0
Fork 0
mirror of https://github.com/deepseek-ai/DeepGEMM.git synced 2026-11-05 00:47:26 +00:00
Code Issues 162 Projects Packages Wiki Activity

[GH-ISSUE #339] [BUG] Mega MoE kernel中的小错误 #171

New issue
Closed
opened 2026-10-26 21:14:06 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 21:14:06 +00:00
Owner
Copy link

Originally created by @Yyf1023 on GitHub (May 25, 2026).
Original GitHub issue: https://github.com/deepseek-ai/DeepGEMM/issues/339

开发者们你们好，最近测试mega moe kernel中发现了一个代码中的小错误，起因是我在测试hidden=8192, num_tokens=1024时下面assertion错误：
github.com/deepseek-ai/DeepGEMM@714dd1a4a9/deep_gemm/include/deep_gemm/impls/sm100_fp8_fp4_mega_moe.cuh (L1260)
我本想修改代码以支持8192，但是发现该错误大概率是由于前面对SMEM_BEFORE_BARRIER_SIZE计算错误引起，计算SMEM_BEFORE_BARRIER_SIZE时忘记考虑了SF size：
github.com/deepseek-ai/DeepGEMM@714dd1a4a9/deep_gemm/include/deep_gemm/impls/sm100_fp8_fp4_mega_moe.cuh (L209-L210)
修改为如下即可

constexpr uint32_t SMEM_BEFORE_BARRIER_SIZE = 
-     SMEM_EXPERT_COUNT_SIZE + SMEM_SEND_BUFFER_SIZE + SMEM_CD_SIZE + kNumStages * (SMEM_A_SIZE_PER_STAGE + SMEM_B_SIZE_PER_STAGE); 
+     SMEM_EXPERT_COUNT_SIZE + SMEM_SEND_BUFFER_SIZE + SMEM_CD_SIZE + kNumStages * (SMEM_A_SIZE_PER_STAGE + SMEM_B_SIZE_PER_STAGE + SMEM_SFA_SIZE_PER_STAGE + SMEM_SFB_SIZE_PER_STAGE);

请修复这个问题

Originally created by @Yyf1023 on GitHub (May 25, 2026). Original GitHub issue: https://github.com/deepseek-ai/DeepGEMM/issues/339 开发者们你们好，最近测试mega moe kernel中发现了一个代码中的小错误，起因是我在测试hidden=8192, num_tokens=1024时下面assertion错误： https://github.com/deepseek-ai/DeepGEMM/blob/714dd1a4a980f7937a74343d19a8eba4fe321480/deep_gemm/include/deep_gemm/impls/sm100_fp8_fp4_mega_moe.cuh#L1260 我本想修改代码以支持8192，但是发现该错误大概率是由于前面对SMEM_BEFORE_BARRIER_SIZE计算错误引起，计算SMEM_BEFORE_BARRIER_SIZE时忘记考虑了SF size： https://github.com/deepseek-ai/DeepGEMM/blob/714dd1a4a980f7937a74343d19a8eba4fe321480/deep_gemm/include/deep_gemm/impls/sm100_fp8_fp4_mega_moe.cuh#L209-L210 修改为如下即可 ```diff constexpr uint32_t SMEM_BEFORE_BARRIER_SIZE = - SMEM_EXPERT_COUNT_SIZE + SMEM_SEND_BUFFER_SIZE + SMEM_CD_SIZE + kNumStages * (SMEM_A_SIZE_PER_STAGE + SMEM_B_SIZE_PER_STAGE); + SMEM_EXPERT_COUNT_SIZE + SMEM_SEND_BUFFER_SIZE + SMEM_CD_SIZE + kNumStages * (SMEM_A_SIZE_PER_STAGE + SMEM_B_SIZE_PER_STAGE + SMEM_SFA_SIZE_PER_STAGE + SMEM_SFB_SIZE_PER_STAGE); ``` 请修复这个问题
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
public-sync-20261014
0930-release
nv_dev
fix-mega-moe-fence
public-release-2609
public-release-2607
public-release-2606
mega-update
public-release-260416
ko3n1g/ci/build-wheels
nv_dev_f8e8fb5
nv_dev_950d31a
nv_dev_67fc648
nv_dev_c491439
nv_dev_4ff3f54
v2.1.1.post3
v2.1.1.post2
v2.1.1.post1
v2.1.1
v2.1.0
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepGEMM#171
No description provided.