[PR #29] [CLOSED] Remove if else check in the loop #212

Closed
opened 2026-10-26 21:14:55 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepGEMM/pull/29
Author: @A-transformer
Created: 2/27/2025
Status: ❌ Closed

Base: main ← Head: remove-if_else-check


📝 Commits (2)

  • a2e0d68 Merge pull request #2 from deepseek-ai/main
  • b0b9e03 refactor the loop if/else check

📊 Changes

1 file changed (+10 additions, -7 deletions)

View changed files

📝 deep_gemm/include/deep_gemm/fp8_gemm.cuh (+10 -7)

📄 Description

Keeps DivisibleK and NotDivisibleK logic explicit
Ensures clear separation between the bulk iterations and the last special case
Easier to modify later if conditions change


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepGEMM/pull/29 **Author:** [@A-transformer](https://github.com/A-transformer) **Created:** 2/27/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `remove-if_else-check` --- ### 📝 Commits (2) - [`a2e0d68`](https://github.com/deepseek-ai/DeepGEMM/commit/a2e0d68eed35c9dcf78ce07d1a7576bd006ff17e) Merge pull request #2 from deepseek-ai/main - [`b0b9e03`](https://github.com/deepseek-ai/DeepGEMM/commit/b0b9e03345dc6c788ff999d6d984d719ca15366b) refactor the loop if/else check ### 📊 Changes **1 file changed** (+10 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `deep_gemm/include/deep_gemm/fp8_gemm.cuh` (+10 -7) </details> ### 📄 Description Keeps DivisibleK and NotDivisibleK logic explicit Ensures clear separation between the bulk iterations and the last special case Easier to modify later if conditions change --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 21:14:55 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepGEMM#212
No description provided.