[PR #30] [CLOSED] Specify uint8_t as enum class size #214

New issue

Closed

opened 2026-10-26 21:14:57 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 21:14:57 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepGEMM/pull/30
Author: @ColinPeppler
Created: 2/28/2025
Status: ❌ Closed

Base: main ← Head: one-byte-enum-size

📝 Commits (1)

261fff9 Specify uint8_t as enum size

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 deep_gemm/include/deep_gemm/fp8_gemm.cuh (+1 -1)
📝 deep_gemm/include/deep_gemm/scheduler.cuh (+1 -1)

📄 Description

utilizing the smallest possible underlying type for the enum class: Layout and GemmType

$ python tests/test_jit.py
NVCC compiler: ('/usr/local/cuda-12.4/bin/nvcc', '12.4')
...
JIT test passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepGEMM/pull/30 **Author:** [@ColinPeppler](https://github.com/ColinPeppler) **Created:** 2/28/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `one-byte-enum-size` --- ### 📝 Commits (1) - [`261fff9`](https://github.com/deepseek-ai/DeepGEMM/commit/261fff9c48d6904d1f98ee3e864dcb857265de83) Specify uint8_t as enum size ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `deep_gemm/include/deep_gemm/fp8_gemm.cuh` (+1 -1) 📝 `deep_gemm/include/deep_gemm/scheduler.cuh` (+1 -1) </details> ### 📄 Description utilizing the smallest possible underlying type for the enum class: `Layout` and `GemmType` ``` $ python tests/test_jit.py NVCC compiler: ('/usr/local/cuda-12.4/bin/nvcc', '12.4') ... JIT test passed ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 21:14:57 +00:00