[PR #80] [MERGED] Fix linking error from ODR violation #236

New issue

Closed

opened 2026-10-26 21:15:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 21:15:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepGEMM/pull/80
Author: @abcdabcd987
Created: 4/5/2025
Status: ✅ Merged
Merged: 4/7/2025
Merged by: @LyricZhao

Base: main ← Head: fix-link-error

📝 Commits (1)

611e3f6 Fix linking error from ODR violation

📊 Changes

2 files changed (+4 additions, -4 deletions)

View changed files

📝 deep_gemm/include/deep_gemm/mma_utils.cuh (+3 -3)
📝 deep_gemm/include/deep_gemm/tma_utils.cuh (+1 -1)

📄 Description

Some functions missed inline specifier. In JIT mode, it's fine. However, in our use case, we AOT compile and link all kernels into one binary and these functions causes linking error.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepGEMM/pull/80 **Author:** [@abcdabcd987](https://github.com/abcdabcd987) **Created:** 4/5/2025 **Status:** ✅ Merged **Merged:** 4/7/2025 **Merged by:** [@LyricZhao](https://github.com/LyricZhao) **Base:** `main` ← **Head:** `fix-link-error` --- ### 📝 Commits (1) - [`611e3f6`](https://github.com/deepseek-ai/DeepGEMM/commit/611e3f659ddb2f69e8132ed26240120e1d2d2705) Fix linking error from ODR violation ### 📊 Changes **2 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `deep_gemm/include/deep_gemm/mma_utils.cuh` (+3 -3) 📝 `deep_gemm/include/deep_gemm/tma_utils.cuh` (+1 -1) </details> ### 📄 Description Some functions missed `inline` specifier. In JIT mode, it's fine. However, in our use case, we AOT compile and link all kernels into one binary and these functions causes linking error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 21:15:10 +00:00