deepseek-ai/DeepGEMM
1
0
Fork 0
mirror of https://github.com/deepseek-ai/DeepGEMM.git synced 2026-11-05 00:47:26 +00:00
Code Issues 162 Projects Packages Wiki Activity

[PR #234] [MERGED] Better error handling, code consistency, compile-time safety #305

New issue
Closed
opened 2026-10-26 21:16:04 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 21:16:04 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/DeepGEMM/pull/234
Author: @ajwise9
Created: 11/28/2025
Status: ✅ Merged
Merged: 12/5/2025
Merged by: @LyricZhao

Base: main ← Head: main

📝 Commits (1)

  • 78e97ca Better error handling, code consistency, compile-time safety

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 setup.py (+1 -1)

📄 Description

Add nodiscard to early_return for compile-time safety

Added the [[nodiscard]] attribute to the [early_return] function in [gemm.hpp] to prevent potential logic bugs as I ran into a couple, where the return value might be accidentally ignored.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/DeepGEMM/pull/234 **Author:** [@ajwise9](https://github.com/ajwise9) **Created:** 11/28/2025 **Status:** ✅ Merged **Merged:** 12/5/2025 **Merged by:** [@LyricZhao](https://github.com/LyricZhao) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`78e97ca`](https://github.com/deepseek-ai/DeepGEMM/commit/78e97caffe99a51cff5a9a660dde8682fa8c7fb7) Better error handling, code consistency, compile-time safety ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `setup.py` (+1 -1) </details> ### 📄 Description # Add [[nodiscard]] to early_return for compile-time safety ## Added the `[[nodiscard]]` attribute to the [early_return] function in [gemm.hpp] to prevent potential logic bugs as I ran into a couple, where the return value might be accidentally ignored. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-26 21:16:04 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
public-sync-20261014
0930-release
nv_dev
fix-mega-moe-fence
public-release-2609
public-release-2607
public-release-2606
mega-update
public-release-260416
ko3n1g/ci/build-wheels
nv_dev_f8e8fb5
nv_dev_950d31a
nv_dev_67fc648
nv_dev_c491439
nv_dev_4ff3f54
v2.1.1.post3
v2.1.1.post2
v2.1.1.post1
v2.1.1
v2.1.0
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepGEMM#305
No description provided.