deepseek-ai/DeepGEMM
1
0
Fork 0
mirror of https://github.com/deepseek-ai/DeepGEMM.git synced 2026-11-05 00:47:26 +00:00
Code Issues 162 Projects Packages Wiki Activity

[GH-ISSUE #161] Suspicious condition in is_block_size_legal #93

New issue
Closed
opened 2026-10-26 21:12:17 +00:00 by bsakaguchi · 1 comment
bsakaguchi commented 2026-10-26 21:12:17 +00:00
Owner
Copy link

Originally created by @ankutalev on GitHub (Aug 14, 2025).
Original GitHub issue: https://github.com/deepseek-ai/DeepGEMM/issues/161

Hello! Got this error trying to build DeepGEMM manually.

overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
   42 | if (((block_n > 128) && (kernel_type == KernelType::Kernel1D2D)) && ((block_n != 144) || (block_n != 160))) { 
      |                                                                      ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
heuristics/sm90.hpp:40:87: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
   40 | if (((block_n > 128) && (kernel_type == KernelType::Kernel1D1D)) && ((block_n != 136) || (block_n != 152)))

The error valid - this part of condition always evaluates to True.
Perhaps it should be and, not or :

if (((block_n > 128) && (kernel_type == KernelType::Kernel1D1D)) && ((block_n != 136) && (block_n != 152)))

The issue reproducible on current main https://github.com/deepseek-ai/DeepGEMM/blob/main/csrc/jit_kernels/heuristics/sm90.hpp#L39

I can make PR with fix if you wish

Originally created by @ankutalev on GitHub (Aug 14, 2025). Original GitHub issue: https://github.com/deepseek-ai/DeepGEMM/issues/161 Hello! Got this error trying to build DeepGEMM manually. ``` overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare] 42 | if (((block_n > 128) && (kernel_type == KernelType::Kernel1D2D)) && ((block_n != 144) || (block_n != 160))) { | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ heuristics/sm90.hpp:40:87: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare] 40 | if (((block_n > 128) && (kernel_type == KernelType::Kernel1D1D)) && ((block_n != 136) || (block_n != 152))) ``` The error valid - this part of condition always evaluates to True. Perhaps it should be and, not or : ``` if (((block_n > 128) && (kernel_type == KernelType::Kernel1D1D)) && ((block_n != 136) && (block_n != 152))) ``` The issue reproducible on current main https://github.com/deepseek-ai/DeepGEMM/blob/main/csrc/jit_kernels/heuristics/sm90.hpp#L39 I can make PR with fix if you wish
bsakaguchi commented 2026-10-26 21:12:19 +00:00
Author
Owner
Copy link

@LyricZhao commented on GitHub (Aug 22, 2025):

Fixed in #164, thanks!

<!-- gh-comment-id:3213732844 --> @LyricZhao commented on GitHub (Aug 22, 2025): Fixed in #164, thanks!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
public-sync-20261014
0930-release
nv_dev
fix-mega-moe-fence
public-release-2609
public-release-2607
public-release-2606
mega-update
public-release-260416
ko3n1g/ci/build-wheels
nv_dev_f8e8fb5
nv_dev_950d31a
nv_dev_67fc648
nv_dev_c491439
nv_dev_4ff3f54
v2.1.1.post3
v2.1.1.post2
v2.1.1.post1
v2.1.1
v2.1.0
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/DeepGEMM#93
No description provided.