[PR #21] feat: Add Python packaging support and fix typo #22

Open
opened 2026-10-26 21:06:50 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/ESFT/pull/21
Author: @yurekami
Created: 12/25/2025
Status: 🔄 Open

Base: main ← Head: feat/add-packaging-and-fixes


📝 Commits (1)

  • 305dd64 feat: Add Python packaging support and fix typo

📊 Changes

3 files changed (+99 additions, -3 deletions)

View changed files

📝 __init__.py (+48 -0)
📝 esft.py (+3 -3)
➕ pyproject.toml (+48 -0)

📄 Description

Summary

  • Adds pyproject.toml for pip installation support
  • Adds proper exports to __init__.py with __version__
  • Fixes typo in docstring: "parameterss" -> "parameters"
  • Translates Chinese comments to English for consistency

Changes

New file: pyproject.toml

  • Modern build system configuration (PEP 517/518)
  • Package metadata and dependencies
  • Optional dependencies for evaluation

Modified: __init__.py

  • Added module docstring
  • Added __version__ = "1.0.0"
  • Added exports for main functions:
    • to_buffer, to_param, to_esft
    • load_state_dict, load_esft_model, load_base_model
    • add_adapter

Modified: esft.py

  • Fixed typo in to_param docstring: "parameterss" -> "parameters"
  • Translated comments from Chinese to English:
    • "初始化空的 state_dict" -> "Initialize empty state_dict"
    • "遍历文件夹中的所有文件" -> "Iterate through all files in the folder"

Installation

Users can now install via pip:

pip install git+https://github.com/deepseek-ai/ESFT.git

Or for development:

git clone https://github.com/deepseek-ai/ESFT.git
cd ESFT
pip install -e .

Test plan

  • Verify Python syntax is valid
  • Verify pyproject.toml is valid
  • Test pip installation
  • Verify imports work correctly

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/ESFT/pull/21 **Author:** [@yurekami](https://github.com/yurekami) **Created:** 12/25/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/add-packaging-and-fixes` --- ### 📝 Commits (1) - [`305dd64`](https://github.com/deepseek-ai/ESFT/commit/305dd64f832b4fe0464ffceb6ed5d361aafcec0f) feat: Add Python packaging support and fix typo ### 📊 Changes **3 files changed** (+99 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `__init__.py` (+48 -0) 📝 `esft.py` (+3 -3) ➕ `pyproject.toml` (+48 -0) </details> ### 📄 Description ## Summary - Adds `pyproject.toml` for pip installation support - Adds proper exports to `__init__.py` with `__version__` - Fixes typo in docstring: "parameterss" -> "parameters" - Translates Chinese comments to English for consistency ## Changes ### New file: `pyproject.toml` - Modern build system configuration (PEP 517/518) - Package metadata and dependencies - Optional dependencies for evaluation ### Modified: `__init__.py` - Added module docstring - Added `__version__ = "1.0.0"` - Added exports for main functions: - `to_buffer`, `to_param`, `to_esft` - `load_state_dict`, `load_esft_model`, `load_base_model` - `add_adapter` ### Modified: `esft.py` - Fixed typo in `to_param` docstring: "parameterss" -> "parameters" - Translated comments from Chinese to English: - "初始化空的 state_dict" -> "Initialize empty state_dict" - "遍历文件夹中的所有文件" -> "Iterate through all files in the folder" ## Installation Users can now install via pip: ```bash pip install git+https://github.com/deepseek-ai/ESFT.git ``` Or for development: ```bash git clone https://github.com/deepseek-ai/ESFT.git cd ESFT pip install -e . ``` ## Test plan - [x] Verify Python syntax is valid - [x] Verify pyproject.toml is valid - [ ] Test pip installation - [ ] Verify imports work correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/ESFT#22
No description provided.