deepseek-ai/Janus
1
0
Fork 0
mirror of https://github.com/deepseek-ai/Janus.git synced 2026-11-05 00:57:18 +00:00
Code Issues 183 Projects Packages Wiki Activity

[GH-ISSUE #17] Just wondering: why do you choose LLamaGen as image tokenizer, instead of OpenMagViT2? #13

New issue
Closed
opened 2026-10-26 21:10:01 +00:00 by bsakaguchi · 5 comments
bsakaguchi commented 2026-10-26 21:10:01 +00:00
Owner
Copy link

Originally created by @StarCycle on GitHub (Oct 22, 2024).
Original GitHub issue: https://github.com/deepseek-ai/Janus/issues/17

Hello @hills-code @TheOneTrueGuy @eltociear,

It's definately a nice work! I am just wondering: why do you choose LLamaGen as image tokenizer, instead of OpenMagViT2? It seems that OpenMagViT2 has better performance and I am using it...If you do the ablation which shows LLamaGen looks better, please let me know and I will also switch my image tokenizer...

Great thanks!

Originally created by @StarCycle on GitHub (Oct 22, 2024). Original GitHub issue: https://github.com/deepseek-ai/Janus/issues/17 Hello @hills-code @TheOneTrueGuy @eltociear, It's definately a nice work! I am just wondering: why do you choose LLamaGen as image tokenizer, instead of OpenMagViT2? It seems that OpenMagViT2 has better performance and I am using it...If you do the ablation which shows LLamaGen looks better, please let me know and I will also switch my image tokenizer... Great thanks!
bsakaguchi commented 2026-10-26 21:10:03 +00:00
Author
Owner
Copy link

@TheOneTrueGuy commented on GitHub (Oct 22, 2024):

Why am I linked in this? I have almost nothing to do with this except contributing a single trivial file.

<!-- gh-comment-id:2428141127 --> @TheOneTrueGuy commented on GitHub (Oct 22, 2024): Why am I linked in this? I have almost nothing to do with this except contributing a single trivial file.
bsakaguchi commented 2026-10-26 21:10:04 +00:00
Author
Owner
Copy link

@StarCycle commented on GitHub (Oct 22, 2024):

@TheOneTrueGuy Oh sorry I just saw you in the contributors

<!-- gh-comment-id:2428147377 --> @StarCycle commented on GitHub (Oct 22, 2024): @TheOneTrueGuy Oh sorry I just saw you in the contributors
bsakaguchi commented 2026-10-26 21:10:04 +00:00
Author
Owner
Copy link

@TheOneTrueGuy commented on GitHub (Oct 22, 2024):

de nada, sorry I can't answer your question. I'm still just getting started
learning about Janus. Good luck.

<!-- gh-comment-id:2428192627 --> @TheOneTrueGuy commented on GitHub (Oct 22, 2024): de nada, sorry I can't answer your question. I'm still just getting started learning about Janus. Good luck.
bsakaguchi commented 2026-10-26 21:10:05 +00:00
Author
Owner
Copy link

@charlesCXK commented on GitHub (Oct 22, 2024):

@StarCycle
Hi, we directly used the LlamaGen Tokenizer and haven't tried OpenMagViT2. When we started the project, OpenMagViT2 wasn't available yet. We believe that using a better tokenizer can result in better generation results.

<!-- gh-comment-id:2428619289 --> @charlesCXK commented on GitHub (Oct 22, 2024): @StarCycle Hi, we directly used the LlamaGen Tokenizer and haven't tried OpenMagViT2. When we started the project, OpenMagViT2 wasn't available yet. We believe that using a better tokenizer can result in better generation results.
bsakaguchi commented 2026-10-26 21:10:05 +00:00
Author
Owner
Copy link

@StarCycle commented on GitHub (Oct 22, 2024):

@charlesCXK

Thanks! I see!

<!-- gh-comment-id:2428908726 --> @StarCycle commented on GitHub (Oct 22, 2024): @charlesCXK Thanks! I see!
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/Janus#13
No description provided.