deepseek-ai/Janus
1
0
Fork 0
mirror of https://github.com/deepseek-ai/Janus.git synced 2026-11-05 00:57:18 +00:00
Code Issues 183 Projects Packages Wiki Activity

[PR #115] Remove duplicate SentencePiece package declaration #218

New issue
Open
opened 2026-10-26 21:14:12 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-26 21:14:12 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/deepseek-ai/Janus/pull/115
Author: @yschungmr
Created: 1/31/2025
Status: 🔄 Open

Base: main ← Head: main

📝 Commits (1)

  • a7060db fix: remove duplicate SentencePiece package from requirements.txt

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 requirements.txt (+0 -1)

📄 Description

Description:
This PR addresses a redundancy in the requirements.txt file by removing the duplicate declaration of the SentencePiece package. Currently, the package is listed twice:

  • As sentencepiece (lowercase, no version specified)
  • As SentencePiece==0.1.96 (with specific version)

Changes made:

  • Removed the unversioned sentencepiece entry
  • Retained SentencePiece==0.1.96 for version consistency

Rationale:

  • Python packages are case-insensitive, making these entries effectively duplicate
  • Keeping the versioned dependency ensures reproducible builds
  • This change maintains project stability while cleaning up the dependency list

Testing:

  • Verified that the project builds successfully with the updated requirements.txt
  • Confirmed all dependent functionality remains intact

Please review and merge if appropriate.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/deepseek-ai/Janus/pull/115 **Author:** [@yschungmr](https://github.com/yschungmr) **Created:** 1/31/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`a7060db`](https://github.com/deepseek-ai/Janus/commit/a7060db42e0787a5b682ec14d7b51d02161949b3) fix: remove duplicate SentencePiece package from requirements.txt ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `requirements.txt` (+0 -1) </details> ### 📄 Description Description: This PR addresses a redundancy in the requirements.txt file by removing the duplicate declaration of the SentencePiece package. Currently, the package is listed twice: - As `sentencepiece` (lowercase, no version specified) - As `SentencePiece==0.1.96` (with specific version) Changes made: - Removed the unversioned `sentencepiece` entry - Retained `SentencePiece==0.1.96` for version consistency Rationale: - Python packages are case-insensitive, making these entries effectively duplicate - Keeping the versioned dependency ensures reproducible builds - This change maintains project stability while cleaning up the dependency list Testing: - Verified that the project builds successfully with the updated requirements.txt - Confirmed all dependent functionality remains intact Please review and merge if appropriate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
deepseek-ai/Janus#218
No description provided.