[PR #149] [MERGED] Match Docker container lifecycle semantics #150

Closed
opened 2026-10-15 12:52:22 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/149
Author: @JBailes
Created: 7/27/2026
Status: ✅ Merged
Merged: 7/27/2026
Merged by: @JBailes

Base: main ← Head: fix/docker-lifecycle-parity


📝 Commits (2)

  • 6f62a49 fix(images): resolve app bases as explicit LXC distros
  • 5f621ce fix(gc): match Docker auto-remove lifecycle

📊 Changes

5 files changed (+97 additions, -140 deletions)

View changed files

📝 internal/image/resolver.go (+10 -3)
📝 internal/image/resolver_test.go (+8 -1)
📝 internal/lxc/gc_test.go (+65 -0)
📝 internal/lxc/manager.go (+14 -117)
📝 internal/lxc/manager_test.go (+0 -19)

📄 Description

Summary

  • garbage-collect only started, exited containers created with AutoRemove
  • remove Wolf/SmoothNAS name and label ownership heuristics from engine GC
  • make known-app base pulls explicitly select linuxcontainers.org distro templates

Validation

  • go test ./...
  • explicit lifecycle matrix covers running/created/exited persistent/exited AutoRemove containers

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/149 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 7/27/2026 **Status:** ✅ Merged **Merged:** 7/27/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/docker-lifecycle-parity` --- ### 📝 Commits (2) - [`6f62a49`](https://github.com/games-on-whales/LXC2Docker/commit/6f62a4972b0a8a181e55d440aa19973e08de0241) fix(images): resolve app bases as explicit LXC distros - [`5f621ce`](https://github.com/games-on-whales/LXC2Docker/commit/5f621ce65b354729fb1861a6f6e381d804aca12f) fix(gc): match Docker auto-remove lifecycle ### 📊 Changes **5 files changed** (+97 additions, -140 deletions) <details> <summary>View changed files</summary> 📝 `internal/image/resolver.go` (+10 -3) 📝 `internal/image/resolver_test.go` (+8 -1) 📝 `internal/lxc/gc_test.go` (+65 -0) 📝 `internal/lxc/manager.go` (+14 -117) 📝 `internal/lxc/manager_test.go` (+0 -19) </details> ### 📄 Description ## Summary - garbage-collect only started, exited containers created with AutoRemove - remove Wolf/SmoothNAS name and label ownership heuristics from engine GC - make known-app base pulls explicitly select linuxcontainers.org distro templates ## Validation - go test ./... - explicit lifecycle matrix covers running/created/exited persistent/exited AutoRemove containers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-15 12:52:22 +00:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
games-on-whales/LXC2Docker#150
No description provided.