[PR #16] [MERGED] Improve Portainer compatibility coverage #17

New issue

Closed

opened 2026-10-15 12:51:19 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:19 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/16
Author: @JBailes
Created: 4/18/2026
Status: ✅ Merged
Merged: 4/18/2026
Merged by: @JBailes

Base: main ← Head: ci/test-matrix-ci

📝 Commits (10+)

b5d0b94 Wire up Portainer commit and plugins endpoints
ecf1651 Fix distribution inspect payload compatibility for Portainer
1d4e366 Wire images/load route to real handler
3632158 Expose image save routes for Portainer
423e944 Implement local Docker image search endpoint for Portainer
15bdbe7 Wire build and container export handlers for Portainer
d3a3e3f Return swarm unavailable responses for swarm-related routes
b86e20e Add Portainer HEAD coverage for missing endpoints
f8d449b Persist Portainer container update settings
aca2fd5 Implement persisted Portainer network lifecycle

📊 Changes

41 files changed (+5262 additions, -451 deletions)

View changed files

📝 cmd/docker-lxc-daemon/main.go (+3 -3)
📝 go.mod (+1 -1)
📝 internal/api/build.go (+340 -135)
➕ internal/api/build_portainer_test.go (+138 -0)
➕ internal/api/commit_body_portainer_test.go (+143 -0)
➕ internal/api/commit_changes_portainer_test.go (+129 -0)
➕ internal/api/commit_portainer_test.go (+162 -0)
➕ internal/api/commit_snapshot_portainer_test.go (+46 -0)
📝 internal/api/containers.go (+164 -34)
📝 internal/api/containers_extra.go (+110 -8)
📝 internal/api/events.go (+114 -18)
➕ internal/api/events_portainer_test.go (+260 -0)
📝 internal/api/exec.go (+78 -27)
➕ internal/api/exec_detachkeys_portainer_test.go (+41 -0)
➕ internal/api/exec_pid_portainer_test.go (+42 -0)
➕ internal/api/exec_portainer_test.go (+41 -0)
➕ internal/api/image_advanced_portainer_test.go (+99 -0)
➕ internal/api/image_console_portainer_test.go (+115 -0)
➕ internal/api/image_portainer_roundtrip_test.go (+170 -0)
➕ internal/api/image_provenance_portainer_test.go (+117 -0)

...and 21 more files

📄 Description

Summary

improve Portainer round-tripping for container stdio metadata and exec inspect payloads
normalize engine and volume metadata shapes to match Docker responses more closely
add focused compatibility regression tests

Testing

GOCACHE=/tmp/go-build-cache go test ./internal/api

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/16 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 4/18/2026 **Status:** ✅ Merged **Merged:** 4/18/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `ci/test-matrix-ci` --- ### 📝 Commits (10+) - [`b5d0b94`](https://github.com/games-on-whales/LXC2Docker/commit/b5d0b94b1f6ea5c5127ed5b183c106428e4cae29) Wire up Portainer commit and plugins endpoints - [`ecf1651`](https://github.com/games-on-whales/LXC2Docker/commit/ecf165116960d8fcbefa45a1be5f0dc0a6ece71f) Fix distribution inspect payload compatibility for Portainer - [`1d4e366`](https://github.com/games-on-whales/LXC2Docker/commit/1d4e3664e5080a5ddbcbb71d6790022516d44dad) Wire images/load route to real handler - [`3632158`](https://github.com/games-on-whales/LXC2Docker/commit/3632158aa540811e3f65b2ece74fa0cfca63019b) Expose image save routes for Portainer - [`423e944`](https://github.com/games-on-whales/LXC2Docker/commit/423e944820cb097c928f44245114a8e37a58afb5) Implement local Docker image search endpoint for Portainer - [`15bdbe7`](https://github.com/games-on-whales/LXC2Docker/commit/15bdbe7221771a2f800bc4f104bf3f8d2af3e2d7) Wire build and container export handlers for Portainer - [`d3a3e3f`](https://github.com/games-on-whales/LXC2Docker/commit/d3a3e3f3a33ffd2c9df3201c92ea26cbdcb5f712) Return swarm unavailable responses for swarm-related routes - [`b86e20e`](https://github.com/games-on-whales/LXC2Docker/commit/b86e20e61ba2493c318c6015ecf911dbdd107d46) Add Portainer HEAD coverage for missing endpoints - [`f8d449b`](https://github.com/games-on-whales/LXC2Docker/commit/f8d449b7e005c1c7616156c23168cfa2603b0632) Persist Portainer container update settings - [`aca2fd5`](https://github.com/games-on-whales/LXC2Docker/commit/aca2fd58cd863aa3c493d6eafcffd7f17a41581b) Implement persisted Portainer network lifecycle ### 📊 Changes **41 files changed** (+5262 additions, -451 deletions) <details> <summary>View changed files</summary> 📝 `cmd/docker-lxc-daemon/main.go` (+3 -3) 📝 `go.mod` (+1 -1) 📝 `internal/api/build.go` (+340 -135) ➕ `internal/api/build_portainer_test.go` (+138 -0) ➕ `internal/api/commit_body_portainer_test.go` (+143 -0) ➕ `internal/api/commit_changes_portainer_test.go` (+129 -0) ➕ `internal/api/commit_portainer_test.go` (+162 -0) ➕ `internal/api/commit_snapshot_portainer_test.go` (+46 -0) 📝 `internal/api/containers.go` (+164 -34) 📝 `internal/api/containers_extra.go` (+110 -8) 📝 `internal/api/events.go` (+114 -18) ➕ `internal/api/events_portainer_test.go` (+260 -0) 📝 `internal/api/exec.go` (+78 -27) ➕ `internal/api/exec_detachkeys_portainer_test.go` (+41 -0) ➕ `internal/api/exec_pid_portainer_test.go` (+42 -0) ➕ `internal/api/exec_portainer_test.go` (+41 -0) ➕ `internal/api/image_advanced_portainer_test.go` (+99 -0) ➕ `internal/api/image_console_portainer_test.go` (+115 -0) ➕ `internal/api/image_portainer_roundtrip_test.go` (+170 -0) ➕ `internal/api/image_provenance_portainer_test.go` (+117 -0) _...and 21 more files_ </details> ### 📄 Description ## Summary - improve Portainer round-tripping for container stdio metadata and exec inspect payloads - normalize engine and volume metadata shapes to match Docker responses more closely - add focused compatibility regression tests ## Testing - GOCACHE=/tmp/go-build-cache go test ./internal/api --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:51:19 +00:00