[PR #25] [MERGED] fix: sanitize OCI template hostnames #26

New issue

Closed

opened 2026-10-15 12:51:24 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 12:51:24 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/games-on-whales/LXC2Docker/pull/25
Author: @JBailes
Created: 5/17/2026
Status: ✅ Merged
Merged: 5/17/2026
Merged by: @JBailes

Base: main ← Head: fix/sanitize-template-hostnames

📝 Commits (1)

2590b05 fix: sanitize OCI template hostnames

📊 Changes

4 files changed (+35 additions, -2 deletions)

View changed files

📝 internal/image/resolver.go (+10 -1)
📝 internal/image/resolver_test.go (+12 -0)
📝 internal/lxc/manager.go (+1 -1)
📝 internal/lxc/manager_test.go (+12 -0)

📄 Description

Summary

keep OCI template container names free of registry/tag dots
write DNS-safe lxc.uts.name values for legacy OCI template configs
add coverage for registry-dot template names and hostname sanitization

Tests

gofmt
git diff --check
go test ./internal/image
go test ./internal/lxc ./internal/api on SmoothNAS host for prior raw-label patch

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/games-on-whales/LXC2Docker/pull/25 **Author:** [@JBailes](https://github.com/JBailes) **Created:** 5/17/2026 **Status:** ✅ Merged **Merged:** 5/17/2026 **Merged by:** [@JBailes](https://github.com/JBailes) **Base:** `main` ← **Head:** `fix/sanitize-template-hostnames` --- ### 📝 Commits (1) - [`2590b05`](https://github.com/games-on-whales/LXC2Docker/commit/2590b05455c2ce2ab0670456ee83f1c7b4fb69b3) fix: sanitize OCI template hostnames ### 📊 Changes **4 files changed** (+35 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/image/resolver.go` (+10 -1) 📝 `internal/image/resolver_test.go` (+12 -0) 📝 `internal/lxc/manager.go` (+1 -1) 📝 `internal/lxc/manager_test.go` (+12 -0) </details> ### 📄 Description ## Summary - keep OCI template container names free of registry/tag dots - write DNS-safe lxc.uts.name values for legacy OCI template configs - add coverage for registry-dot template names and hostname sanitization ## Tests - gofmt - git diff --check - go test ./internal/image - go test ./internal/lxc ./internal/api on SmoothNAS host for prior raw-label patch --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 12:51:24 +00:00